From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 1ED8F5930
 for <dev@dpdk.org>; Tue, 22 Jul 2014 03:23:43 +0200 (CEST)
Received: from cpe-098-026-076-128.nc.res.rr.com ([98.26.76.128]
 helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1X9Oot-0003eS-5T; Mon, 21 Jul 2014 21:24:48 -0400
Date: Mon, 21 Jul 2014 21:24:41 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Message-ID: <20140722012440.GA13452@localhost.localdomain>
References: <CAE4G5iryAeKytnVLvpFoL7CmrnXxo_Gw0cmwOaAzNvvagr3QEg@mail.gmail.com>
 <20140721195415.GA25740@hmsreliant.think-freely.org>
 <20140721134350.70ad9fba@haswell>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140721134350.70ad9fba@haswell>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Random numbers at line-rate
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jul 2014 01:23:43 -0000

On Mon, Jul 21, 2014 at 01:43:50PM -0700, Stephen Hemminger wrote:
> On Mon, 21 Jul 2014 15:54:15 -0400
> Neil Horman <nhorman@tuxdriver.com> wrote:
> 
> > On Mon, Jul 21, 2014 at 09:24:36PM +0200, Chris Pappas wrote:
> > > Hi,
> > > 
> > > I need to generate a random number per packet and I used the rte_fast_rand
> > > function to do so. When I run the code for one port-core I get almost
> > > line-rate performance. However, running simultaneously on multiple cores
> > > degrades performance significantly. (in all cases I uses minimum-sized
> > > packets).
> > > 
> > > Shouldn't the implementation scale for multicore and not degrade
> > > performance or am I missing anything? Also, is there another recommendation
> > > for generating randomness at line-rate? (the cpu does not support rdrand).
> > > 
> > > Best regards,
> > > Chris
> > > 
> > 
> > thats an odd random number generator.  I think, without locking, its likely on a
> > multicore system to produce identical values on multiple cores operating in
> > parallel (since multiple cores can read rte_red_rand_seed at the same time).
> > That may well lead to multiple packets having the same nonce, which might cause
> > odd behavior.
> > 
> > If your cpu supports it, I'd suggest writing some inline assembly to use the
> > rdrand instruction instead.  I'm not sure about its performance relative to the
> > current implementation, but IIRC the instruction is handled internal to the
> > core, so it should scale with any number of cpus.
> > 
> > neil
> > 
> 
> Or  just do per-core seed value (and use RTE_PER_LCORE)
rte_fast_rand doesn't seem like it can take advantage of per lcore variables.
Generally speaking its not multi-threaded at all from what I can see.
neil

>