From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 0B0FA5930 for ; Tue, 22 Jul 2014 19:42:00 +0200 (CEST) Received: by mail-pa0-f51.google.com with SMTP id ey11so12337866pad.24 for ; Tue, 22 Jul 2014 10:43:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=LdpxvnQY6VgQElkcVjm/IXXDuZF4zEdLzFSAifZDDhM=; b=LtZEXdPcIvEJ/alrktZoFsdfvfCLBhRhgF8S/nSZK99s/HgCdI2MauMbpo+Ygrmm9f bzB7Vxl8B2n4RhxJmAhV7JPuDdXjQQFD9BZBLqL8kh5wQ4YHpXs1XPVAJKbNLRZt+4ac Nwq69fQ5tSFYUE7DuYOIvzMH8WfNaKWJeoAW2/FVOweUeYkuuvVS9Mo6374fuJ2Q6/SJ iRoRDNCHTB5oIfPIleFrrFEQb1PDZa3QtMNST6tc3G6/oZUzApqhuvKoE14g2hgPRDVJ TmlmHYVRMIFSpDwuEQ0yjxFN6o3Aa+NXiEVe6RPFbk+Mnvp01x7TOSrODO+xyYcLTRln +qYA== X-Gm-Message-State: ALoCoQnhFUEEA/H5JskHwUzbo4Dhgawy3RcbbJ6Yz4Y1CDA4ufdavROxvE/XEEeNdxMFrGNJb4us X-Received: by 10.70.35.169 with SMTP id i9mr3928958pdj.36.1406050999791; Tue, 22 Jul 2014 10:43:19 -0700 (PDT) Received: from haswell (static-50-53-72-226.bvtn.or.frontiernet.net. [50.53.72.226]) by mx.google.com with ESMTPSA id k9sm1353974pdo.28.2014.07.22.10.43.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jul 2014 10:43:19 -0700 (PDT) Date: Tue, 22 Jul 2014 10:43:21 -0700 From: Stephen Hemminger To: Ouyang Changchun Message-ID: <20140722104321.6107c937@haswell> In-Reply-To: <1406015252-27804-2-git-send-email-changchun.ouyang@intel.com> References: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com> <1406015252-27804-2-git-send-email-changchun.ouyang@intel.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/3] ether: Update field name and description for queue start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2014 17:42:01 -0000 On Tue, 22 Jul 2014 15:47:30 +0800 Ouyang Changchun wrote: > + /**< If rx_enable_queue is true, rte_eth_dev_rx_queue_start must be > + invocated after rte_eth_dev_start's invocation to start RX for > + one queue, and rte_eth_dev_rx_queue_start instead of > + rte_eth_dev_start is responsible for allocating mbuf from > + mempool and setup the DMA physical address. It is useful in > + such scenario: buffer address is not available at the point of > + rte_eth_dev_start's invocation but available later, e.g. in > + VHOST zero copy case, the buffer address to be setup DMA > + address is available only after one VM startup. */ Good documentation about semantics is really valuable as long as it kept up to date. In this case, the comment stands out which is not a good thing. An explanation this long belongs in documentation not in code. Alternatively, if it is this hard to explain maybe it isn't the right design :-)