From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
 [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 17287959
 for <dev@dpdk.org>; Wed, 23 Jul 2014 20:06:32 +0200 (CEST)
Received: by mail-pa0-f48.google.com with SMTP id et14so2197163pad.7
 for <dev@dpdk.org>; Wed, 23 Jul 2014 11:07:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=HY/ZtUKATYzQVUsvZQeV6MTWaSr3ixV83TcRlNq6Hls=;
 b=Wf7x7s/ayWKmTmPbJw33DLjDL341DsHs07AkPDOsIpzYtpjP+iTv4OADreWqHZ4HYt
 HBye6Yd7ygImmXap56g5OLacWg/JgocJyzm1Eb2pg3mAh0epwINJbmRJFOEn8m2YVdS1
 O1STHd+sQMUNAb/3V17Rik19lc6eungbjg8skGU+f1StK0B+lmcT44DisvNaZHN7pE+c
 ALkI7WDtlJQuRYyVxrBcQhxPHgb7oPIpttVrCdX/RmCnnGwSaFOAOl89dZTciDZ+nxi9
 LYqrxOJz7D7xf7wv5G0dUKZfqDlpFZ2KKn+Yk0ZhCEbBjC1QzgZI0xeMkWft4l+9Voc5
 Vb/w==
X-Gm-Message-State: ALoCoQnywtfjIA75niQe87IHAAlJWBQGkgE4E5LB4rlf4Cn9NfXfiZV/MM3rwkh8KAPPxKNurqgv
X-Received: by 10.70.89.139 with SMTP id bo11mr4195849pdb.50.1406138876595;
 Wed, 23 Jul 2014 11:07:56 -0700 (PDT)
Received: from haswell (static-50-53-72-226.bvtn.or.frontiernet.net.
 [50.53.72.226])
 by mx.google.com with ESMTPSA id d3sm4029316pdi.49.2014.07.23.11.07.55
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 23 Jul 2014 11:07:56 -0700 (PDT)
Date: Wed, 23 Jul 2014 11:07:58 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yerden Zhumabekov <e_zhumabekov@sts.kz>
Message-ID: <20140723110758.1c08c259@haswell>
In-Reply-To: <1406086726-54032-2-git-send-email-e_zhumabekov@sts.kz>
References: <1406086726-54032-1-git-send-email-e_zhumabekov@sts.kz>
 <1406086726-54032-2-git-send-email-e_zhumabekov@sts.kz>
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fall back to enable/disable irq mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jul 2014 18:06:33 -0000

On Wed, 23 Jul 2014 09:38:46 +0600
Yerden Zhumabekov <e_zhumabekov@sts.kz> wrote:

> Rewritten IRQ mode handling code introduced in commit 399a3f0d
> (igb_uio: fix IRQ mode handling) renders some faulty NICs (VMware
> e1000, for example) unusable if INTX mode is not supported.
> 
> This patch gets these NICs up and running, but throwing a kernel
> warning.
> 
> Signed-off-by: Yerden Zhumabekov <e_zhumabekov@sts.kz>

That is because the VMWare PCI INTX is broken.
The masking logic doesn't work.

Rather than applying this patch a deeper fix in E1000 and DPDK handling
of link state is needed. Better to just make the E1000 able
to function without IRQ for Link state than just pretend masking works.