From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 4FD1AB362 for ; Wed, 23 Jul 2014 20:07:48 +0200 (CEST) Received: by mail-pa0-f48.google.com with SMTP id et14so2197457pad.35 for ; Wed, 23 Jul 2014 11:09:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=AX2wHJG7vjwqs/ULMmBY3u42onVnCHU/8m1Ko1Q/w1A=; b=m6bQY2PlVdd8jSI2TytGRR7SZA535kxKQX9Vz9o7Yu00voVBcq+PtuCFm86+a/kOlJ 2Zziphgw/jBX472KeFQNQ+dzPi46AsmBHTcwBBXVg9kQpeKWTkvzgIWQQ4Oc3x1xpXvm hYjwKeUDgiyjjT0soAh3Ovov0Wf7p4ASrYRx3LfOzR1E8QHdNOmGG7vxGDaZvOwNW5NR 6KGUAIUUtf0e6rZjtZAJpO+QktAauaW1Y7CMdajqXNkYv/wt5Jg5shxKIgifMWX/F3zf pXY4ZeZHaVMtFiYpKbC8TalxYWdyqRfZvVN10D1jNbLjB2KyjXrc2Pv8BgrWkkHr+A8r WOIA== X-Gm-Message-State: ALoCoQkvxN6A75+/6xjTiedmLAWYI/3Yq07uDMPiFx2IpOYYzefi9mhKl6144Qr584Kx6DaC+K15 X-Received: by 10.68.115.48 with SMTP id jl16mr4220958pbb.78.1406138952085; Wed, 23 Jul 2014 11:09:12 -0700 (PDT) Received: from haswell (static-50-53-72-226.bvtn.or.frontiernet.net. [50.53.72.226]) by mx.google.com with ESMTPSA id pn4sm3063520pbb.7.2014.07.23.11.09.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jul 2014 11:09:11 -0700 (PDT) Date: Wed, 23 Jul 2014 11:09:14 -0700 From: Stephen Hemminger To: Yerden Zhumabekov Message-ID: <20140723110914.6b6902e8@haswell> In-Reply-To: <1406086726-54032-2-git-send-email-e_zhumabekov@sts.kz> References: <1406086726-54032-1-git-send-email-e_zhumabekov@sts.kz> <1406086726-54032-2-git-send-email-e_zhumabekov@sts.kz> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] igb_uio: fall back to enable/disable irq mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2014 18:07:48 -0000 On Wed, 23 Jul 2014 09:38:46 +0600 Yerden Zhumabekov wrote: > Rewritten IRQ mode handling code introduced in commit 399a3f0d > (igb_uio: fix IRQ mode handling) renders some faulty NICs (VMware > e1000, for example) unusable if INTX mode is not supported. > > This patch gets these NICs up and running, but throwing a kernel > warning. > > Signed-off-by: Yerden Zhumabekov That is because the VMWare PCI INTX is broken. The masking logic doesn't work. Rather than applying this patch a deeper fix in E1000 and DPDK handling of link state is needed. Better to just make the E1000 able to function without IRQ for Link state than just pretend masking works