From: Stephen Hemminger <stephen@networkplumber.org>
To: Yerden Zhumabekov <e_zhumabekov@sts.kz>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fall back to enable/disable irq mode
Date: Thu, 24 Jul 2014 08:11:06 -0700 [thread overview]
Message-ID: <20140724081106.1c2bae0c@haswell.linuxnetplumber.net> (raw)
In-Reply-To: <53D07968.8030105@sts.kz>
On Thu, 24 Jul 2014 09:11:36 +0600
Yerden Zhumabekov <e_zhumabekov@sts.kz> wrote:
> 24.07.2014 0:09, Stephen Hemminger пишет:
> >> Rewritten IRQ mode handling code introduced in commit 399a3f0d
> >> (igb_uio: fix IRQ mode handling) renders some faulty NICs (VMware
> >> e1000, for example) unusable if INTX mode is not supported.
> >>
> >> This patch gets these NICs up and running, but throwing a kernel
> >> warning.
> >>
> >> Signed-off-by: Yerden Zhumabekov <e_zhumabekov@sts.kz>
> > That is because the VMWare PCI INTX is broken.
> > The masking logic doesn't work.
> >
> > Rather than applying this patch a deeper fix in E1000 and DPDK handling
> > of link state is needed. Better to just make the E1000 able
> > to function without IRQ for Link state than just pretend masking works
>
> I'll dig deeper then, maybe I'll figure out something.
> If IRQ doesn't hook anything then, I guess, NIC should be continuously
> checked for link state. If so, where should I put my efforts? PMD?
>
I think what would be the best fix is:
1. In igb_uio, if INTX test fails then setup with interrupts. This can be done by
setting the irq # to 0. UIO in kernel will then setup device without any IRQ support
2. In DPDK, change PCI code to handle case of UIO without interrupts, and set flag
in the device structure.
3. In an accessor function in rte_ethdev layer add new function
rte_eth_dev_has_link_intr() which checks for RTE_PCI_DRV_INTR_LSC flag
and that interrupt setup was successful.
4. Application only configures dev_conf->intr_conf.lsc iff device
supports it (see check #3)
prev parent reply other threads:[~2014-07-24 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 3:38 [dpdk-dev] [PATCH] igb_uio dropped support for some faulty NICs Yerden Zhumabekov
2014-07-23 3:38 ` [dpdk-dev] [PATCH] igb_uio: fall back to enable/disable irq mode Yerden Zhumabekov
2014-07-23 18:07 ` Stephen Hemminger
2014-07-23 18:09 ` Stephen Hemminger
2014-07-24 3:11 ` Yerden Zhumabekov
2014-07-24 15:11 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724081106.1c2bae0c@haswell.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=e_zhumabekov@sts.kz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).