From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id AD6F7ADBE for ; Wed, 30 Jul 2014 21:26:57 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1XCZYM-0008WB-RV; Wed, 30 Jul 2014 15:28:53 -0400 Date: Wed, 30 Jul 2014 15:28:44 -0400 From: Neil Horman To: Bruce Richardson Message-ID: <20140730192844.GB3296@hmsreliant.think-freely.org> References: <1406665466-29654-1-git-send-email-nhorman@tuxdriver.com> <20140730185902.GA6420@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140730185902.GA6420@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2] dpdk: Allow for dynamic enablement of some isolated features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jul 2014 19:26:57 -0000 On Wed, Jul 30, 2014 at 11:59:03AM -0700, Bruce Richardson wrote: > On Tue, Jul 29, 2014 at 04:24:24PM -0400, Neil Horman wrote: > > Hey all- > > I've been trying to update the fedora dpdk package to support VFIO > > enabled drivers and ran into a problem in which ixgbe didn't compile because the > > rxtx_vec code uses sse4.2 instruction intrinsics, which aren't supported in the > > default config I have. I tried to remedy this by replacing the intrinsics with > > the __builtin macros, but it was pointed out (correctly), that this doesn't work > > properly. So this is my second attempt, which I actually like a bit better. I > > noted that code that uses intrinsics (ixgbe and the acl library), don't need to > > have those instructions turned on build-wide. Rather, we can just enable the > > instructions in the specific code we want to build with support for that, and > > test for instruction support dynamically at run time. This allows me to build > > the dpdk for a generic platform, but in such a way that some optimizations can > > be used if the executing cpu supports them at run time. > > > > Signed-off-by: Neil Horman > > CC: Thomas Monjalon > > > I'd prefer if a solution could be found based off your original patch > set, as it gives us more chance to deprecate the older code paths in > future. Looking at the Intel Intrinsics Guide site online, it shows that > the _mm_shuffle_epi8 intrinsic came in with SSSE3, rather than SSE4.x, > and so should be available on all 64-bit systems, I believe. The > popcount intrinsic is newer, but it's a much more basic instruction so > hopefully the __builtin should work for that. > Yes, but as I look at it, thats somewhat counter to my goal, which is to offer accelerated code paths on systems that can make use of it at run time. If We use the __builtin compiler functions, we will either: 1) Build those code paths with advanced instructions that won't work on older systems (i.e. crash) 2) Build those code paths with less advanced instructions, meaning that we won't speedup execution on systems that are capable of using the more advanced instructions. Using this run time check, we can, at least in these situations, make use of the accelerated paths when the instructions are available, and ignore them when they're not, at run time. What would be ideal, would be an alternative type macro, like the linux kernel employs, but implementing that would require some pretty significant work and testing. This seems like a much simpler approach. Neil > Regards, > /Bruce >