From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com
 [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 02B595926
 for <dev@dpdk.org>; Fri,  1 Aug 2014 17:51:56 +0200 (CEST)
Received: by mail-pd0-f174.google.com with SMTP id fp1so5749322pdb.5
 for <dev@dpdk.org>; Fri, 01 Aug 2014 08:54:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=S8QOM1exwGU5rfFhInUmH95KFg7FqqCddslP59wHFj0=;
 b=N9qhHAe54xz4xzrcp5XQFtY78mSDSajOtmywjnaQDx+cIWtE7m1vhcoROuyiZ1v6vO
 IWsVgqOglBZcVhby/Xv8vJgLJhb0qX4JqwI6KBlxkc/80nKONC1qX8VHyqV86O+duUp9
 paXBPDu9QzgVPvb1rZcQ+eDe4GAH0jmzPiOZ4Xv3jNDMyRxpJgDfyBfSp0/hT+zwrXfu
 WJhvOAUAcu8iWSNrHt4fXGeDF1gTO59XepBTOAElBD1JQXWOJLqNN+/XDZecMuAUvjHc
 Ot7xPgwE9Z4vVy+g4dcWMub+buX1nkGi6tT4n4NBxyOQuLfTGULhhJpq7a+k6xjzSmPZ
 9/Jw==
X-Gm-Message-State: ALoCoQliYiknspR3tdvqH0bUu78IGgZP+Uvlr/vdq5wZ/pwEBU+xkSq7mIKwDNYERSkbaYnu/b/3
X-Received: by 10.68.95.225 with SMTP id dn1mr7272880pbb.126.1406908441512;
 Fri, 01 Aug 2014 08:54:01 -0700 (PDT)
Received: from haswell.linuxnetplumber.net
 (static-50-53-72-226.bvtn.or.frontiernet.net. [50.53.72.226])
 by mx.google.com with ESMTPSA id ny7sm31592644pab.48.2014.08.01.08.54.00
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 01 Aug 2014 08:54:01 -0700 (PDT)
Date: Fri, 1 Aug 2014 08:53:56 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20140801085356.64eb5bb7@haswell.linuxnetplumber.net>
In-Reply-To: <2434669.uPKS10IHqv@xps13>
References: <20140725105037.26769945@haswell.linuxnetplumber.net>
 <2434669.uPKS10IHqv@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH]  vmxnet3: initialize receive mode correctly
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Aug 2014 15:51:57 -0000

On Fri, 01 Aug 2014 16:50:06 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2014-07-25 10:50, Stephen Hemminger:
> > The driver must listen to broadcast packets, like other devices.
> > Otherwise protocols like ARP won't work!
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> > -	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> > +	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
> 
> It's also removing multicast at init. No comment so I assume everybody agrees.

Just following what initial value for bare metal drivers is.