From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <nhorman@tuxdriver.com> Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 8B63668AE for <dev@dpdk.org>; Fri, 1 Aug 2014 15:35:02 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from <nhorman@tuxdriver.com>) id 1XDD0y-0005sa-Qv; Fri, 01 Aug 2014 09:37:03 -0400 Date: Fri, 1 Aug 2014 09:36:55 -0400 From: Neil Horman <nhorman@tuxdriver.com> To: Bruce Richardson <bruce.richardson@intel.com> Message-ID: <20140801133655.GA31979@hmsreliant.think-freely.org> References: <1406665466-29654-1-git-send-email-nhorman@tuxdriver.com> <20140730210920.GB6420@localhost.localdomain> <20140731131351.GA20718@hmsreliant.think-freely.org> <5766264.li3nkTmgY6@xps13> <20140731143228.GB20718@hmsreliant.think-freely.org> <20140731181032.GC20718@hmsreliant.think-freely.org> <20140731183631.GC6420@localhost.localdomain> <20140731190117.GD20718@hmsreliant.think-freely.org> <20140731201949.GA28495@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140731201949.GA28495@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2] dpdk: Allow for dynamic enablement of some isolated features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 01 Aug 2014 13:35:02 -0000 On Thu, Jul 31, 2014 at 01:19:50PM -0700, Bruce Richardson wrote: > On Thu, Jul 31, 2014 at 03:01:17PM -0400, Neil Horman wrote: > > On Thu, Jul 31, 2014 at 11:36:32AM -0700, Bruce Richardson wrote: > > > > > > I think a good first step here that I can't see anyone objecting to is > > > to enable the ixgbe driver to use the vector code path for a generic > > > x86_64 build. I've run a quick test here, and changing "_mm_popcnt_u64" > > > to "__builtin_popcountll" [and the include from nmmintrin to tmmintrin] > > > allows a compile for machine type default, and testpmd can still forward > > > packets at a good rate (roughly perf down about 10% vs native compile on > > > SNB). > > > The ACL is a tougher nut to crack, but anyone see any issues with that > > > two-line change to ixgbe_rxtx_vec.c? [Neil, since you started the patch > > > set thread, do you want to submit an official patch here, or would you prefer I > > > do so?] > > > > > > > I'm happy to do so, Though 10% performance degradation vs. using the sse4.2 > > instructions in that path seems significant, isn't it? Given that performance > > delta, it seems like it would still be preferable to have a path that used the > > sse4.2 instructions when they're available. Or am I misreading what you mean > > when you say down 10% > > > > Neil > > > Ok, I did a little bit more testing here. Using the vector pmd compiled > for generic x86_64 and using __builtin_popcountll is approx 35% faster > for packet IO than the existing fast-path functions. It is also 7% (a > bit lower than ~10% as I originally stated) slower than the existing > native-compiled vpmd on a Sandy Bridge platform. > > I then ran an extra test, using EXTRA_CFLAGS='-msse4.2' to turn on the > extra instructions. The ~7% performance drop went to ~3%, so we would > gain a little more with using SSE4.2, but compared to the gain from > having the vector driver at all, it's not that much. [I don't have a > system handy with AVX2 support to see what boosts might come from > compiling with that instruction set enabled.] > > Because of this, I'd take the ~35% speed boost for now, and try and find > what would be the best general way to solve this problem across all > libraries. Also, I think that anyone who needs that extra 4% performance > probably wants the other 3% too, and so will compile up the code from > source using the "native" compilation target. :-) > Wait a moment, I'm not entirely sure what you did here. I understand that you replaced the _mm_popcnt_u64 call in the ixgbe pmd vector receive path with __builtin_popcnt, which is good, but ixgbe also uses the __mm_shuffle_epi8 intrinsic which is only available with sse4.2 from what I can see. did you replace those calls with a __builtin_shuffle variant? Otherwise, how did you get the pmd to build? I'm asking because this is what I tried in the first pass and Konstantin gave some pretty convicing evidence that this was an unworkable solution: http://dpdk.org/ml/archives/dev/2014-July/004443.html Neil