From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/7] fix build errors
Date: Mon, 18 Aug 2014 13:57:21 +0100 [thread overview]
Message-ID: <20140818125721.GA4278@sivswdev02.ir.intel.com> (raw)
In-Reply-To: <1408361365-12988-1-git-send-email-david.marchand@6wind.com>
On Mon, Aug 18, 2014 at 01:29:18PM +0200, David Marchand wrote:
> This patch series resolves build errors I encountered after disabling some parts
> of the dpdk.
>
> - simplified app/*/Makefile,
> - fixed some build error when disabling refcnt,
> - removed dead code (reference to pm_autotest),
> - reworked all the tests from app/test to use a dynamic register mechanism
> (this makes it easier to enable/disable them),
> - reworked app/test Makefile to only enable the relevant tests.
>
> Changes since v1:
> - fixed typo in first patch (RTE_CONFIG.. in app/test/Makefile)
>
> --
> David Marchand
>
This looks like a good idea to me, simplifies the code and the boiler-plate work to be done when adding new tests.
Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2014-08-18 12:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 11:29 David Marchand
2014-08-18 11:29 ` [dpdk-dev] [PATCH v2 1/7] app: simplify makefiles David Marchand
2014-08-18 11:29 ` [dpdk-dev] [PATCH v2 2/7] app/test: use accessor to set refcnt field David Marchand
2014-08-18 11:29 ` [dpdk-dev] [PATCH v2 3/7] app/test: remove pm_autotest David Marchand
2014-08-18 11:29 ` [dpdk-dev] [PATCH v2 4/7] app/test: introduce dynamic commands list David Marchand
2014-08-18 11:29 ` [dpdk-dev] [PATCH v2 5/7] app/test: convert all tests to register system David Marchand
2014-08-18 11:29 ` [dpdk-dev] [PATCH v2 6/7] app/test: no more builtin commands David Marchand
2014-08-18 11:29 ` [dpdk-dev] [PATCH v2 7/7] app/test: only build what has been selected in config David Marchand
2014-08-18 12:57 ` Bruce Richardson [this message]
2014-08-26 15:58 ` [dpdk-dev] [PATCH v2 0/7] fix build errors Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140818125721.GA4278@sivswdev02.ir.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).