From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 05ED0B361 for ; Mon, 18 Aug 2014 16:04:22 +0200 (CEST) Received: from cpe-098-026-066-094.nc.res.rr.com ([98.26.66.94] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1XJNay-0003no-JK; Mon, 18 Aug 2014 10:07:43 -0400 Date: Mon, 18 Aug 2014 10:07:35 -0400 From: Neil Horman To: David Marchand Message-ID: <20140818140735.GA31958@hmsreliant.think-freely.org> References: <1408353973-16663-1-git-send-email-david.marchand@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408353973-16663-1-git-send-email-david.marchand@6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/7] fix build errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Aug 2014 14:04:22 -0000 On Mon, Aug 18, 2014 at 11:26:06AM +0200, David Marchand wrote: > This patch series resolves build errors I encountered after disabling some parts > of the dpdk. > > - simplified app/*/Makefile, > - fixed some build error when disabling refcnt, > - removed dead code (reference to pm_autotest), > - reworked all the tests from app/test to use a dynamic register mechanism > (this makes it easier to enable/disable them), > - reworked app/test Makefile to only enable the relevant tests. > > -- > David Marchand > > David Marchand (7): > app: simplify makefiles > app/test: use accessor to set refcnt field > app/test: remove pm_autotest > app/test: introduce dynamic commands list > app/test: convert all tests to register system > app/test: no more builtin commands > app/test: only build what has been selected in config > > app/cmdline_test/Makefile | 8 +- > app/dump_cfg/Makefile | 5 +- > app/test-acl/Makefile | 9 +- > app/test-pipeline/Makefile | 26 ++--- > app/test-pmd/Makefile | 40 ++++---- > app/test/Makefile | 145 ++++++++++++++++------------ > app/test/autotest_data.py | 6 -- > app/test/commands.c | 193 ++++++++------------------------------ > app/test/test.c | 5 + > app/test/test.h | 74 +++++---------- > app/test/test_acl.c | 18 ++-- > app/test/test_alarm.c | 7 +- > app/test/test_atomic.c | 7 +- > app/test/test_byteorder.c | 8 +- > app/test/test_cmdline.c | 11 ++- > app/test/test_common.c | 8 +- > app/test/test_cpuflags.c | 8 +- > app/test/test_cycles.c | 8 +- > app/test/test_debug.c | 8 +- > app/test/test_devargs.c | 8 +- > app/test/test_distributor.c | 22 ++--- > app/test/test_distributor_perf.c | 20 ++-- > app/test/test_eal_flags.c | 20 ++-- > app/test/test_eal_fs.c | 17 ++-- > app/test/test_errno.c | 8 +- > app/test/test_func_reentrancy.c | 8 +- > app/test/test_hash.c | 19 ++-- > app/test/test_hash_perf.c | 19 ++-- > app/test/test_interrupts.c | 7 +- > app/test/test_ivshmem.c | 15 +-- > app/test/test_kni.c | 18 ++-- > app/test/test_kvargs.c | 9 +- > app/test/test_link_bonding.c | 8 +- > app/test/test_logs.c | 8 +- > app/test/test_lpm.c | 19 ++-- > app/test/test_lpm6.c | 19 ++-- > app/test/test_malloc.c | 8 +- > app/test/test_mbuf.c | 8 +- > app/test/test_memcpy.c | 8 +- > app/test/test_memcpy_perf.c | 8 +- > app/test/test_memory.c | 8 +- > app/test/test_mempool.c | 8 +- > app/test/test_mempool_perf.c | 8 +- > app/test/test_memzone.c | 8 +- > app/test/test_meter.c | 18 ++-- > app/test/test_mp_secondary.c | 19 +--- > app/test/test_pci.c | 6 ++ > app/test/test_per_lcore.c | 8 +- > app/test/test_pmd_ring.c | 19 ++-- > app/test/test_power.c | 20 ++-- > app/test/test_prefetch.c | 8 +- > app/test/test_red.c | 20 ++-- > app/test/test_ring.c | 8 +- > app/test/test_ring_perf.c | 8 +- > app/test/test_rwlock.c | 8 +- > app/test/test_sched.c | 18 ++-- > app/test/test_spinlock.c | 8 +- > app/test/test_string_fns.c | 8 +- > app/test/test_table.c | 21 ++--- > app/test/test_table.h | 1 - > app/test/test_table_acl.c | 4 - > app/test/test_table_combined.c | 3 - > app/test/test_table_pipeline.c | 8 -- > app/test/test_table_ports.c | 4 - > app/test/test_table_tables.c | 4 - > app/test/test_tailq.c | 8 +- > app/test/test_timer.c | 17 ++-- > app/test/test_timer_perf.c | 17 ++-- > app/test/test_version.c | 8 +- > 69 files changed, 550 insertions(+), 623 deletions(-) > > -- > 1.7.10.4 > > Agree with Bruce here, this is a nice consolidation. Acked-by: Neil Horman