From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com
 [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id 2FADB58D3
 for <dev@dpdk.org>; Sat, 23 Aug 2014 17:11:16 +0200 (CEST)
Received: by mail-pa0-f43.google.com with SMTP id lf10so17920256pab.2
 for <dev@dpdk.org>; Sat, 23 Aug 2014 08:15:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=PMqVVZWOdp0FtNI+2kx72hCevOVKrdaHl6K1gFmZZ/A=;
 b=cELsY7qT2ac+At8ufOXxqEb2iRevnjsmnAoJ6Cj2AVyPmqe5nOgzAgaIrg0YONsmcP
 FXp63pZo7GHtppWI4SkhCLDKD5/xWW/pLl5oLUA4XXaGQezxdcBkkXrnhY1pqApH4M7X
 0vhsHyR6HmPXbSFHrXm73krz3oy5PIYSwL3KIQ+N4LVAnj1BmTVhIgTiaWA4lx2WvrZM
 FuVDfSfTT9a7z8wfMFt45m3sbA7EIP6aWdxhwKBtvQ0aSKNTK1m6Gh6O5x/5JOZLMepm
 w+Aq7ZpCnby74mBI1FioufYOOs/IlAKPyN3lPx+7s94GdY8Tx6yNlA7hD/2mLk8IbG+v
 XEIg==
X-Gm-Message-State: ALoCoQn8lblF0MOEhyLQs01Q9Sb5Ob54glSOdExuXzsQQjf0oa44uiMU2auEQLSgNpFu8uWnaWDG
X-Received: by 10.70.34.16 with SMTP id v16mr14057496pdi.153.1408806901667;
 Sat, 23 Aug 2014 08:15:01 -0700 (PDT)
Received: from uryu.home.lan (static-50-53-65-80.bvtn.or.frontiernet.net.
 [50.53.65.80])
 by mx.google.com with ESMTPSA id am2sm32029401pbc.59.2014.08.23.08.15.00
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Sat, 23 Aug 2014 08:15:01 -0700 (PDT)
Date: Sat, 23 Aug 2014 08:14:53 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Robert Sanford <rsanford2@gmail.com>
Message-ID: <20140823081453.6e3ae5d7@uryu.home.lan>
In-Reply-To: <CA+cr1coJs9yokaDT1ya=5ChSWuSYWiF4TqmAhpcP0qLZKC4odA@mail.gmail.com>
References: <20140725103627.4ca989b7@haswell.linuxnetplumber.net>
 <9317787.qKVt3oyQbN@xps13> <D01CF3B4.28B5%rsanford@akamai.com>
 <CA+cr1coJs9yokaDT1ya=5ChSWuSYWiF4TqmAhpcP0qLZKC4odA@mail.gmail.com>
X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] igb_uio: fix compability on old kernel
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Aug 2014 15:11:16 -0000

On Fri, 22 Aug 2014 14:09:35 -0400
Robert Sanford <rsanford2@gmail.com> wrote:

> This is what we came up with. It works for us. In our kernel headers'
> linux/pci.h, pci_num_vf is enclosed within "#ifdef CONFIG_PCI_IOV/#endif";
> pci_intx_mask_supported and pci_check_and_mask_intx are enclosed within
> "#ifdef HAVE_PCI_SET_MWI/#endif".
> 
> What do you think?

Maybe we can just get rid of kernel version checks all together and
just use the HAVE_ checks.

I will test on stock 2.6.32.