From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly
Date: Mon, 25 Aug 2014 17:33:59 -0700 [thread overview]
Message-ID: <20140825173359.36a95050@urahara> (raw)
In-Reply-To: <2434669.uPKS10IHqv@xps13>
On Fri, 01 Aug 2014 16:50:06 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2014-07-25 10:50, Stephen Hemminger:
> > The driver must listen to broadcast packets, like other devices.
> > Otherwise protocols like ARP won't work!
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> > - vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> > + vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
>
> It's also removing multicast at init. No comment so I assume everybody agrees.
>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> Applied for version 1.7.1.
>
> Thanks
My general rule is to make all drivers behave the same.
In DPDK, the ixgbe driver is the "best known" reference.
In that driver "multicast promiscious" is disabled by default.
next prev parent reply other threads:[~2014-08-26 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 17:50 Stephen Hemminger
2014-08-01 14:50 ` Thomas Monjalon
2014-08-01 15:53 ` Stephen Hemminger
2014-08-26 0:33 ` Stephen Hemminger [this message]
2014-08-26 6:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825173359.36a95050@urahara \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).