From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com
 [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id 1DB203975
 for <dev@dpdk.org>; Tue, 26 Aug 2014 02:30:05 +0200 (CEST)
Received: by mail-pa0-f41.google.com with SMTP id rd3so21981718pab.0
 for <dev@dpdk.org>; Mon, 25 Aug 2014 17:34:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=2qJ0ws+upJVYrok3TxIfNiof+/aistx2jJn2lc9fieQ=;
 b=Qzaqfm++4TOZaFVcJwppPshPqFMgTIT0ip+rrAzFAUUsNFzmTCTN3HdFO5WFy58foP
 Ir8Q8EBTJYxrad92BPOWoqR+lGo5ru9QLNQmI39+0cjWuBxnY7CP/C+FZLKUmgC14iI2
 WwpXon25gmx/EVGKswXTJQhxgYKDTGTOARChqOMkTyHh9ED5h/BEobi/5QpV0nccO67R
 MAa2G1XZd0vHYDtVkbqjWXHRWdjiBzxRX7YNWwum5wNMprpZc7n31dDua25dwbD+haAl
 e+Kxbwm162qyI3INCxwtZfvgkzuphLp2wmYJlDYKKNVOGvI974xTcgRuApErKewUEfqO
 a6zw==
X-Gm-Message-State: ALoCoQkjE5LR95FnidQMBzt7T+z4BrTCHVi6uH12QwzLSiymt94T/7Fi6dvI3zG/Rah0bby7r4O7
X-Received: by 10.70.98.129 with SMTP id ei1mr25960924pdb.27.1409013242577;
 Mon, 25 Aug 2014 17:34:02 -0700 (PDT)
Received: from urahara (static-50-53-65-80.bvtn.or.frontiernet.net.
 [50.53.65.80])
 by mx.google.com with ESMTPSA id wi10sm966169pbc.95.2014.08.25.17.34.01
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 25 Aug 2014 17:34:02 -0700 (PDT)
Date: Mon, 25 Aug 2014 17:33:59 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20140825173359.36a95050@urahara>
In-Reply-To: <2434669.uPKS10IHqv@xps13>
References: <20140725105037.26769945@haswell.linuxnetplumber.net>
 <2434669.uPKS10IHqv@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH]  vmxnet3: initialize receive mode correctly
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Aug 2014 00:30:06 -0000

On Fri, 01 Aug 2014 16:50:06 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2014-07-25 10:50, Stephen Hemminger:
> > The driver must listen to broadcast packets, like other devices.
> > Otherwise protocols like ARP won't work!
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> > -	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> > +	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
> 
> It's also removing multicast at init. No comment so I assume everybody agrees.
> 
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Applied for version 1.7.1.
> 
> Thanks

My general rule is to make all drivers behave the same.
In DPDK, the ixgbe driver is the "best known" reference.
In that driver "multicast promiscious" is disabled by default.