From: Stephen Hemminger <stephen@networkplumber.org>
To: Alex Markuze <alex@weka.io>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] vmxnet3: fix crash on stop
Date: Mon, 25 Aug 2014 17:41:02 -0700 [thread overview]
Message-ID: <20140825174102.3a0989f4@urahara> (raw)
In-Reply-To: <CAKfHP0V4xx3mwg0dYMDFcQOVdN1BfBzuHfnT59KKFVy9LAz70Q@mail.gmail.com>
The cmd_ring_release can be called twice if queue has already
been released. This cause crash on shutdown.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c 2014-08-25 17:39:04.544119911 -0700
+++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c 2014-08-25 17:39:04.544119911 -0700
@@ -173,6 +173,7 @@ vmxnet3_cmd_ring_release(vmxnet3_cmd_rin
vmxnet3_cmd_ring_adv_next2comp(ring);
}
rte_free(ring->buf_info);
+ ring->buf_info = NULL;
}
void
next prev parent reply other threads:[~2014-08-26 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 10:13 [dpdk-dev] Vmxnet3 pmd Alex Markuze
2014-08-13 16:58 ` Patel, Rashmin N
2014-08-26 0:41 ` Stephen Hemminger [this message]
2014-08-29 10:41 ` [dpdk-dev] [PATCH] vmxnet3: fix crash on stop Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825174102.3a0989f4@urahara \
--to=stephen@networkplumber.org \
--cc=alex@weka.io \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).