From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id DF5383975
 for <dev@dpdk.org>; Tue, 26 Aug 2014 02:37:07 +0200 (CEST)
Received: by mail-pd0-f179.google.com with SMTP id v10so21357514pde.24
 for <dev@dpdk.org>; Mon, 25 Aug 2014 17:41:04 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=UnoLj7b/G4b29iidYedxo/EuNGKmUYcVNui6xOyDlDg=;
 b=MORKpU7XT7Ssbqg+ieAbpp46k4M8GMpJp1T0iNIliS9+GX1Xpu08sRCchwRhzpS9AA
 f52jMmKrDxBoViOgNcCidReEC7+547A9eF3ICTEV05bbMsjELepXwNHwQGd+exyWRS1G
 EoqvTV5KrRLWJb7brQDhD9dslXCGrbzLf3lm6LKCWiUX2EZvyAdY8gKkXvYuIZaoisAH
 O2TGlLG/CPFIir2m9ZWBqOICjGpMQNfA5uad06OvOurBYqxh65iABJBLMF2nBQU7RmW8
 PvWCBFIKzeEQ572mwiNqEplUVhxl/+PsJ5nYtxWSxL7U94iEnmr1jb0sdYrJg2fd1WsU
 +B2g==
X-Gm-Message-State: ALoCoQn+IvX+/Lfg+zWCQKTKa7/8v3OJkxUXgOidTqhHu5ctce1M6vU3FieGtv7v8/pCFm9MdMdU
X-Received: by 10.66.65.133 with SMTP id x5mr32198709pas.26.1409013664714;
 Mon, 25 Aug 2014 17:41:04 -0700 (PDT)
Received: from urahara (static-50-53-65-80.bvtn.or.frontiernet.net.
 [50.53.65.80])
 by mx.google.com with ESMTPSA id oh7sm1700333pdb.68.2014.08.25.17.41.04
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 25 Aug 2014 17:41:04 -0700 (PDT)
Date: Mon, 25 Aug 2014 17:41:02 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Alex Markuze <alex@weka.io>
Message-ID: <20140825174102.3a0989f4@urahara>
In-Reply-To: <CAKfHP0V4xx3mwg0dYMDFcQOVdN1BfBzuHfnT59KKFVy9LAz70Q@mail.gmail.com>
References: <CAKfHP0V4xx3mwg0dYMDFcQOVdN1BfBzuHfnT59KKFVy9LAz70Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] vmxnet3: fix crash on stop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Aug 2014 00:37:08 -0000

The cmd_ring_release can be called twice if queue has already
been released. This cause crash on shutdown.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c	2014-08-25 17:39:04.544119911 -0700
+++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c	2014-08-25 17:39:04.544119911 -0700
@@ -173,6 +173,7 @@ vmxnet3_cmd_ring_release(vmxnet3_cmd_rin
 		vmxnet3_cmd_ring_adv_next2comp(ring);
 	}
 	rte_free(ring->buf_info);
+	ring->buf_info = NULL;
 }
 
 void