From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com
 [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 51CCCB390
 for <dev@dpdk.org>; Wed, 27 Aug 2014 20:03:02 +0200 (CEST)
Received: by mail-pa0-f48.google.com with SMTP id et14so798311pad.35
 for <dev@dpdk.org>; Wed, 27 Aug 2014 11:07:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=lagWwcEUBmb0+4K7lpKuam2YQM5+JfbGGTcNNcc1Z14=;
 b=RODaZ+Yhv8OfD2AVURjKXKEp5VCzu11f3doC/la2bsSnmns9J2ZtTR0OnC6O49tjzT
 OyYB+xdg5Aay+O8y6HEWaSTP2opgwBIQM4JCxPh0a9nnbLaHEVh6DLVlTaAA5lUa8hMw
 YxvIBJdm9fd8+ZeEZ9DetzxUaz/No8/aTmjfJC7zFrlwWKOqSTpvIdWx8yLpAXH10WVn
 ktCTvZKoPBZDMNlL4pUsxeaQukAUb/OIeqmoZrwZR1eDkC1Xl+ZEJXtEQQOe/EaLmosR
 SuQbP6Mf2oeLj0QcFlD3Q5a5yc6gtpB6sa5X8Ad59C4XFdeh2k+wAj4s8HZrqoBUIs1u
 Wq4g==
X-Gm-Message-State: ALoCoQkEBMpqT4dJe8g8mfZs0RiBBnmKNYZI9YxiYjT3phLGC218m3tqzufjCKcNaZYHkN4LY9DI
X-Received: by 10.68.175.161 with SMTP id cb1mr47688832pbc.91.1409162822618;
 Wed, 27 Aug 2014 11:07:02 -0700 (PDT)
Received: from urahara (static-50-53-65-80.bvtn.or.frontiernet.net.
 [50.53.65.80])
 by mx.google.com with ESMTPSA id hc11sm1042416pbd.70.2014.08.27.11.07.01
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 27 Aug 2014 11:07:02 -0700 (PDT)
Date: Wed, 27 Aug 2014 11:06:57 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jay Rolette <rolette@infiniteio.com>
Message-ID: <20140827110657.557e0368@urahara>
In-Reply-To: <CADNuJVqKAPqXtZziEfwGa0iLsEg0N9ujFC_6ZbA2z5D2GDat9g@mail.gmail.com>
References: <1409062162-19575-1-git-send-email-david.marchand@6wind.com>
 <1409062162-19575-2-git-send-email-david.marchand@6wind.com>
 <CADNuJVruACvGgoSyN+aWOzPfvJrNPqsvAxwCvs2TxwRbhW+vyw@mail.gmail.com>
 <CALwxeUtqN+vZnHODvNgV7FvGGAKTtr7x2gxnoPosbcJx73sx9Q@mail.gmail.com>
 <CADNuJVqKAPqXtZziEfwGa0iLsEg0N9ujFC_6ZbA2z5D2GDat9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 01/11] ixgbe: clean log messages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Aug 2014 18:03:02 -0000

On Wed, 27 Aug 2014 08:53:46 -0500
Jay Rolette <rolette@infiniteio.com> wrote:

> The updated output is definitely an improvement, but if you'll go with the
> first solution you described (adding \n in the log macro), it works much
> better for products using DPDK. For developer use, I think it ends up being
> a wash either way.

Also for driver consistency, all drivers must do the same thing. I.e the PMD_INIT_LOG
macro should either add or not add newline in the same way in all drivers.
I fixed virtio and vmxnet3 by just taking extra newlines out of messages
and leaving the macro alone.