DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Xie, Huawei" <huawei.xie@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch
Date: Tue, 2 Sep 2014 23:01:53 -0700
Message-ID: <20140902230153.0f4f4375@urahara> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F2847A0@SHSMSX101.ccr.corp.intel.com>

On Wed, 3 Sep 2014 05:39:24 +0000
"Xie, Huawei" <huawei.xie@intel.com> wrote:

> Thanks Tetsuya:
> 	Some of them are due to 80 character limitation. Is it ok to break the limitation for better indentation?

Many of these comments could just be removed or shortened.
Often removing comments makes code clearer and less buggy, because
there is no risk that comment does not match code.

  reply	other threads:[~2014-09-03  5:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02  8:55 [dpdk-dev] [PATCH 0/3] Transform the vhost example to two parts: vhost library and example Huawei Xie
2014-09-02  8:55 ` [dpdk-dev] [PATCH 1/3] examples/vhost: remove vhost example Huawei Xie
2014-09-02  8:55 ` [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch Huawei Xie
2014-09-03  3:38   ` Tetsuya.Mukawa
2014-09-03  5:39     ` Xie, Huawei
2014-09-03  6:01       ` Stephen Hemminger [this message]
2014-09-03  9:43         ` Ananyev, Konstantin
2014-09-03  6:43       ` Tetsuya.Mukawa
2014-09-02  8:55 ` [dpdk-dev] [PATCH 3/3] examples/vhost: vhost example based on vhost library Huawei Xie
2014-09-02  9:38 ` [dpdk-dev] [PATCH 0/3] Transform the vhost example to two parts: vhost library and example Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140902230153.0f4f4375@urahara \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git