From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id E6ABF58DF for ; Wed, 3 Sep 2014 07:57:29 +0200 (CEST) Received: by mail-pd0-f182.google.com with SMTP id fp1so10358822pdb.27 for ; Tue, 02 Sep 2014 23:02:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=HcLDbpTyE5VpfO3+EiJ5vFPuQlw4+zMy5H2HLbI4eiw=; b=LetZxuyrvFDl5pOwzBjngRl0p88EDxn8ZuCdTLK/4Kp1Rycu2DSEug7xGMM/6dKHny v7oiQsZPmlWxVN1PhQVT7kiJreL32jm3KoeVAYJjEficC11682cWQl3pgXxwP7RisvpN cmFiiVKe3dny6Yt60HyV4xPVNoazroTdf6hfcgncZrtKys48RjCT5duwdEAtkGyFP9RB 5JY5LcJDs9rw3C6rG9o1UEQS06BOF3j9VwInBd0YFWod3UWz5C1fYNe/4cgJJZ5NgIYN j/aJcp+DD26P+WckQNOn+u2PwZ9llRqfPGpqML1XaKxWtIjLnQ/FM0gUzMBQ+ziJN/3t wCnw== X-Gm-Message-State: ALoCoQnB1aryTjpuX93Gh2zTQJWQgH5C1Q7xSgxjLHmtZhqAtyi9kPQVPwrVLlIpoWEKs4Shj483 X-Received: by 10.66.168.204 with SMTP id zy12mr53320644pab.19.1409724124280; Tue, 02 Sep 2014 23:02:04 -0700 (PDT) Received: from urahara (static-50-53-65-80.bvtn.or.frontiernet.net. [50.53.65.80]) by mx.google.com with ESMTPSA id z4sm7995783pda.23.2014.09.02.23.02.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Sep 2014 23:02:03 -0700 (PDT) Date: Tue, 2 Sep 2014 23:01:53 -0700 From: Stephen Hemminger To: "Xie, Huawei" Message-ID: <20140902230153.0f4f4375@urahara> In-Reply-To: References: <1409648131-4301-1-git-send-email-huawei.xie@intel.com> <1409648131-4301-3-git-send-email-huawei.xie@intel.com> <54068D47.4090401@igel.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2014 05:57:30 -0000 On Wed, 3 Sep 2014 05:39:24 +0000 "Xie, Huawei" wrote: > Thanks Tetsuya: > Some of them are due to 80 character limitation. Is it ok to break the limitation for better indentation? Many of these comments could just be removed or shortened. Often removing comments makes code clearer and less buggy, because there is no risk that comment does not match code.