From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id AE87D68B7 for ; Fri, 12 Sep 2014 14:27:14 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by fmsmga102.fm.intel.com with ESMTP; 12 Sep 2014 05:32:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,513,1406617200"; d="scan'208";a="477111641" Received: from pedersmi-mobl1.ger.corp.intel.com (HELO bricha3-mobl.ir.intel.com) ([10.252.31.133]) by azsmga001.ch.intel.com with SMTP; 12 Sep 2014 05:32:29 -0700 Received: by bricha3-mobl.ir.intel.com (sSMTP sendmail emulation); Fri, 12 Sep 2014 13:32:28 +0001 Date: Fri, 12 Sep 2014 13:32:28 +0100 From: Bruce Richardson To: David Marchand Message-ID: <20140912123227.GA9224@BRICHA3-MOBL> References: <1409567080-27083-1-git-send-email-david.marchand@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1409567080-27083-1-git-send-email-david.marchand@6wind.com> Organization: Intel Shannon Limited. Registered in Ireland. Registered Office: Collinstown Industrial Park, Leixlip, County Kildare. Registered Number: 308263. Business address: Dromore House, East Park, Shannon, Co. Clare. User-Agent: Mutt/1.5.22 (2013-10-16) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Sep 2014 12:27:16 -0000 On Mon, Sep 01, 2014 at 12:24:23PM +0200, David Marchand wrote: > Here is a patchset that reworks the log macro in e1000, ixgbe and i40e PMDs. > The idea behind this is to make it easier to debug some init failures and to be > sure of the datapath selected in these PMDs (rx / tx handlers selection). > > The PMDs changes involve adding more debug messages in the default build. > A new eal option has been added to set the default log level, so that you can > render the eal a little less noisy. > > I did not change the default log level for now, as some eal log messages are > marked as DEBUG while being interesting (from my point of view). > I suppose we can change the default log level later once the eal has been > cleaned up. > > Changes since v2: > - continue clean up by always using PMD_*_LOG when logging something in > PMD (i.e. no more printf, RTE_LOG, DEBUGOUT) > - introduce PMD_DRV_LOG_RAW macro for use by shared driver code > - adopt 'second approach': no more \n in PMD_*_LOG callers. This means that we > will enforce a 'no \n' policy in logs for PMD. > > -- > David Marchand This patch set looks like a definite improvement despite the extra output on startup (which can probably be cleaned up a bit anyway in later patches). Acked-by: Bruce Richardson > > David Marchand (17): > ixgbe: use the right debug macro > ixgbe/base: add a _RAW macro for use by shared code > ixgbe: clean log messages > ixgbe: always log init messages > ixgbe: add a message when forcing scatter mode > ixgbe: add log messages when rx bulk mode is not usable > i40e: use the right debug macro > i40e/base: add a _RAW macro for use by shared code > i40e: clean log messages > i40e: always log init messages > i40e: add log messages when rx bulk mode is not usable > e1000: use the right debug macro > e1000/base: add a _RAW macro for use by shared code > e1000: clean log messages > e1000: always log init messages > e1000: add a message when forcing scatter mode > eal: set log level from command line > > lib/librte_eal/bsdapp/eal/eal.c | 42 ++ > .../bsdapp/eal/include/eal_internal_cfg.h | 1 + > lib/librte_eal/linuxapp/eal/eal.c | 44 +- > .../linuxapp/eal/include/eal_internal_cfg.h | 1 + > lib/librte_pmd_e1000/e1000/e1000_osdep.h | 4 +- > lib/librte_pmd_e1000/e1000_logs.h | 18 +- > lib/librte_pmd_e1000/em_ethdev.c | 64 ++- > lib/librte_pmd_e1000/em_rxtx.c | 137 +++--- > lib/librte_pmd_e1000/igb_ethdev.c | 100 +++-- > lib/librte_pmd_e1000/igb_pf.c | 5 +- > lib/librte_pmd_e1000/igb_rxtx.c | 69 ++-- > lib/librte_pmd_i40e/i40e/i40e_osdep.h | 8 +- > lib/librte_pmd_i40e/i40e_ethdev.c | 434 ++++++++++---------- > lib/librte_pmd_i40e/i40e_ethdev_vf.c | 168 ++++---- > lib/librte_pmd_i40e/i40e_logs.h | 16 +- > lib/librte_pmd_i40e/i40e_pf.c | 79 ++-- > lib/librte_pmd_i40e/i40e_rxtx.c | 201 +++++---- > lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h | 4 +- > lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c | 14 +- > lib/librte_pmd_ixgbe/ixgbe_bypass.c | 26 +- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 177 ++++---- > lib/librte_pmd_ixgbe/ixgbe_fdir.c | 6 +- > lib/librte_pmd_ixgbe/ixgbe_logs.h | 16 +- > lib/librte_pmd_ixgbe/ixgbe_pf.c | 4 +- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 169 +++++--- > 25 files changed, 979 insertions(+), 828 deletions(-) > > -- > 1.7.10.4 >