From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used RHEL 6)
Date: Thu, 18 Sep 2014 08:25:27 -0400 [thread overview]
Message-ID: <20140918122527.GE20389@hmsreliant.think-freely.org> (raw)
In-Reply-To: <5076244.KSjCyF24zI@xps13>
On Thu, Sep 18, 2014 at 01:09:16PM +0200, Thomas Monjalon wrote:
> > The refcnt field is contained within an anonymous union within the mbuf
> > data structure, and gcc 4.4 gives an error about an unknown field unless
> > the initialiser for the field is contained within extra braces.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> Thanks Bruce, it is now applied.
Hang on here, we use anonymous unions all the time in RHEL6, and make
assignments to them frequently, and the compiler doesn't complain (see the
dropcount variable in sk_buff for an example). Not saying that this is a big
deal, but can you explain a little more about what you're seeing when this error
occurs, before we just paper over it?
Neil
> --
> Thomas
>
next prev parent reply other threads:[~2014-09-18 12:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 10:55 Bruce Richardson
2014-09-18 11:09 ` Thomas Monjalon
2014-09-18 12:25 ` Neil Horman [this message]
2014-09-18 12:35 ` Richardson, Bruce
2014-09-18 15:03 ` Neil Horman
2014-09-18 15:16 ` Bruce Richardson
2014-09-18 15:46 ` Neil Horman
2014-09-18 15:38 ` Thomas Monjalon
2014-09-18 15:50 ` Neil Horman
2014-09-18 16:01 ` Richardson, Bruce
2014-09-18 18:12 ` Neil Horman
2014-09-25 2:13 ` Tang, HaifengX
2014-09-25 7:02 ` Thomas Monjalon
2014-09-25 13:07 ` Cao, Waterman
2014-09-25 15:05 ` [dpdk-dev] patches validation Thomas Monjalon
2014-09-25 23:29 ` Ananyev, Konstantin
2014-09-26 9:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918122527.GE20389@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).