From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 85DDAB3A3 for ; Thu, 18 Sep 2014 14:20:03 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1XUam8-0001Oo-8h; Thu, 18 Sep 2014 08:25:44 -0400 Date: Thu, 18 Sep 2014 08:25:27 -0400 From: Neil Horman To: Thomas Monjalon Message-ID: <20140918122527.GE20389@hmsreliant.think-freely.org> References: <1411037752-8000-1-git-send-email-bruce.richardson@intel.com> <5076244.KSjCyF24zI@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5076244.KSjCyF24zI@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used RHEL 6) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2014 12:20:03 -0000 On Thu, Sep 18, 2014 at 01:09:16PM +0200, Thomas Monjalon wrote: > > The refcnt field is contained within an anonymous union within the mbuf > > data structure, and gcc 4.4 gives an error about an unknown field unless > > the initialiser for the field is contained within extra braces. > > > > Signed-off-by: Bruce Richardson > > Acked-by: Thomas Monjalon > > Thanks Bruce, it is now applied. Hang on here, we use anonymous unions all the time in RHEL6, and make assignments to them frequently, and the compiler doesn't complain (see the dropcount variable in sk_buff for an example). Not saying that this is a big deal, but can you explain a little more about what you're seeing when this error occurs, before we just paper over it? Neil > -- > Thomas >