Re: [dpdk-dev] [PATCH 1/7] eal: remove unused --use-device option

[Neil Horman <nhorman@tuxdriver.com>]

On Mon, Sep 22, 2014 at 10:37:55AM +0200, David Marchand wrote:
> Following commit cac6d08c8bde2fdb57806c49038187cdb54219a8 and
> 4bf3fe634a4d9dfce90c4167f3a47d0e2ddf1e64, this option is not available anymore.
> 
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  lib/librte_eal/bsdapp/eal/eal.c   |    7 -------
>  lib/librte_eal/linuxapp/eal/eal.c |    7 -------
>  2 files changed, 14 deletions(-)
> 
> diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
> index 2f84742..ffdc441 100644
> --- a/lib/librte_eal/bsdapp/eal/eal.c
> +++ b/lib/librte_eal/bsdapp/eal/eal.c
> @@ -89,7 +89,6 @@
>  #define OPT_NO_HUGE     "no-huge"
>  #define OPT_FILE_PREFIX "file-prefix"
>  #define OPT_SOCKET_MEM  "socket-mem"
> -#define OPT_USE_DEVICE "use-device"
>  #define OPT_PCI_WHITELIST "pci-whitelist"
>  #define OPT_PCI_BLACKLIST "pci-blacklist"
>  #define OPT_VDEV        "vdev"
> @@ -645,12 +644,6 @@ eal_parse_args(int argc, char **argv)
>  						"FreeBSD\n");
>  				return -1;
>  			}
> -			else if (!strcmp(lgopts[option_index].name, OPT_USE_DEVICE)) {
> -				printf("The --use-device option is deprecated, please use\n"
> -					"--whitelist or --vdev instead.\n");
> -				eal_usage(prgname);
> -				return -1;
> -			}
>  			else if (!strcmp(lgopts[option_index].name, OPT_PCI_BLACKLIST)) {
>  				if (rte_eal_devargs_add(RTE_DEVTYPE_BLACKLISTED_PCI,
>  						optarg) < 0) {
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index 38cace6..633e3b8 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -92,7 +92,6 @@
>  #define OPT_NO_HUGE     "no-huge"
>  #define OPT_FILE_PREFIX "file-prefix"
>  #define OPT_SOCKET_MEM  "socket-mem"
> -#define OPT_USE_DEVICE  "use-device"
>  #define OPT_PCI_WHITELIST "pci-whitelist"
>  #define OPT_PCI_BLACKLIST "pci-blacklist"
>  #define OPT_VDEV        "vdev"
> @@ -880,12 +879,6 @@ eal_parse_args(int argc, char **argv)
>  					return -1;
>  				}
>  			}
> -			else if (!strcmp(lgopts[option_index].name, OPT_USE_DEVICE)) {
> -				printf("The --use-device option is deprecated, please use\n"
> -					"--whitelist or --vdev instead.\n");
> -				eal_usage(prgname);
> -				return -1;
> -			}
>  			else if (!strcmp(lgopts[option_index].name, OPT_PCI_BLACKLIST)) {
>  				if (rte_eal_devargs_add(RTE_DEVTYPE_BLACKLISTED_PCI,
>  						optarg) < 0) {
> -- 
> 1.7.10.4
> 
> 

just a note here - This usage is great reflection of deprecation policy, we
deprecated this back in the 1.6 time frame, left it around for the 1.7 release,
and remove it for the 1.8 release.  I'd love to add some deprecation
functionality to the rte_compat stuff in my patch series on the list so that we
can better announe the deprecation of features/flags/API's in a more general
fashion.

Neil