Re: [dpdk-dev] [PATCH 0/7] cleanup option parsing in bsd/linux eal

[Neil Horman <nhorman@tuxdriver.com>]

On Mon, Sep 22, 2014 at 10:37:54AM +0200, David Marchand wrote:
> Following Neil comments, here is a patchset to rework the eal options parsing.
> I tried to have everything common to linux and bsd in a single file.
> 
> I ran a little make test on linux, it looks fine (at least I have as many fails
> as before my changes).
> 
> There is still work in this part, but I want to stop here.
> If anyone wants to continue ... :-)
> 
> 
> -- 
> David Marchand
> 
> David Marchand (7):
>   eal: remove unused --use-device option
>   eal: factorise unsupported option handling
>   eal: remove duplicate handling of white/black list
>   eal: fix checkpatch issues before moving code
>   eal: merge bsd and linux common options parsing
>   eal: rework long options parsing
>   eal: indent files
> 
>  lib/librte_eal/bsdapp/eal/Makefile          |    1 +
>  lib/librte_eal/bsdapp/eal/eal.c             |  388 +++--------------------
>  lib/librte_eal/common/eal_common_options.c  |  392 +++++++++++++++++++++++
>  lib/librte_eal/common/include/eal_options.h |   84 +++++
>  lib/librte_eal/linuxapp/eal/Makefile        |    1 +
>  lib/librte_eal/linuxapp/eal/eal.c           |  457 +++++----------------------
>  6 files changed, 593 insertions(+), 730 deletions(-)
>  create mode 100644 lib/librte_eal/common/eal_common_options.c
>  create mode 100644 lib/librte_eal/common/include/eal_options.h
> 
> -- 
> 1.7.10.4
> 
> 
Series
ACK