From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 6234E333
 for <dev@dpdk.org>; Mon, 22 Sep 2014 14:37:27 +0200 (CEST)
Received: from [2001:470:8:a08:18c5:c64e:4bf:67a] (helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1XW2xk-00034t-15; Mon, 22 Sep 2014 08:43:29 -0400
Date: Mon, 22 Sep 2014 08:43:27 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: David Marchand <david.marchand@6wind.com>
Message-ID: <20140922124327.GD25406@hmsreliant.think-freely.org>
References: <1411375081-27986-1-git-send-email-david.marchand@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1411375081-27986-1-git-send-email-david.marchand@6wind.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/7] cleanup option parsing in bsd/linux eal
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Sep 2014 12:37:27 -0000

On Mon, Sep 22, 2014 at 10:37:54AM +0200, David Marchand wrote:
> Following Neil comments, here is a patchset to rework the eal options parsing.
> I tried to have everything common to linux and bsd in a single file.
> 
> I ran a little make test on linux, it looks fine (at least I have as many fails
> as before my changes).
> 
> There is still work in this part, but I want to stop here.
> If anyone wants to continue ... :-)
> 
> 
> -- 
> David Marchand
> 
> David Marchand (7):
>   eal: remove unused --use-device option
>   eal: factorise unsupported option handling
>   eal: remove duplicate handling of white/black list
>   eal: fix checkpatch issues before moving code
>   eal: merge bsd and linux common options parsing
>   eal: rework long options parsing
>   eal: indent files
> 
>  lib/librte_eal/bsdapp/eal/Makefile          |    1 +
>  lib/librte_eal/bsdapp/eal/eal.c             |  388 +++--------------------
>  lib/librte_eal/common/eal_common_options.c  |  392 +++++++++++++++++++++++
>  lib/librte_eal/common/include/eal_options.h |   84 +++++
>  lib/librte_eal/linuxapp/eal/Makefile        |    1 +
>  lib/librte_eal/linuxapp/eal/eal.c           |  457 +++++----------------------
>  6 files changed, 593 insertions(+), 730 deletions(-)
>  create mode 100644 lib/librte_eal/common/eal_common_options.c
>  create mode 100644 lib/librte_eal/common/include/eal_options.h
> 
> -- 
> 1.7.10.4
> 
> 
Series
ACK