From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 7C26A333
 for <dev@dpdk.org>; Tue, 23 Sep 2014 14:49:51 +0200 (CEST)
Received: from azsmga001.ch.intel.com ([10.2.17.19])
 by orsmga102.jf.intel.com with ESMTP; 23 Sep 2014 05:49:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,580,1406617200"; d="scan'208";a="479432408"
Received: from bricha3-mobl.ger.corp.intel.com (HELO
 bricha3-mobl.ir.intel.com) ([10.243.20.29])
 by azsmga001.ch.intel.com with SMTP; 23 Sep 2014 05:55:11 -0700
Received: by bricha3-mobl.ir.intel.com (sSMTP sendmail emulation);
 Tue, 23 Sep 2014 13:55:10 +0001
Date: Tue, 23 Sep 2014 13:55:10 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: reshmapa <reshma.pattan@intel.com>
Message-ID: <20140923125510.GB14152@BRICHA3-MOBL>
References: <1410869607-16842-1-git-send-email-reshma.pattan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1410869607-16842-1-git-send-email-reshma.pattan@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/3] distributor_app: new sample application
 for distributor library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Sep 2014 12:49:52 -0000

On Tue, Sep 16, 2014 at 01:13:24PM +0100, reshmapa wrote:
> From: Reshma Pattan <reshma.pattan@intel.com>
> 
> A new sample app that shows the usage of the distributor library. This
> app works as follows:
> 
> *An RX thread runs which pulls packets from each ethernet port in turn
> and passes those packets to worker using a distributor component.
> 
> *The workers take the packets in turn, and determine the output port
> for those packets using basic l2forwarding doing an xor on the source
> port id.
> 
> *The RX thread takes the returned packets from the workers and enqueue
> those packets into an rte_ring structure.
> 
> *A TX thread pulls the packets off the rte_ring structure and then
> sends each packet out the output port specified previously by the worker
> 
> Bruce Richardson (1):
>   distributor_app: new sample app
> 
> Reshma Pattan (2):
>   distributor_app: code review comments implementation
>   distributor_app: removed extra spaces
> 

Since this is just a sample app and the second two patches are just minor 
adjustments to it, I suggest that this be resubmitted as a single patch 
instead of a set. That should also fix the whitespace warnings one gets when 
using "git am" to apply the set.

Please also check the indentation used in the file. I see in a number of 
places that spaces are used instead of tabs for indentation. Running 
checkpatch.pl on the patch before submission should help catch these issues.

Regards,
/Bruce

>  examples/Makefile                 |   1 +
>  examples/distributor_app/Makefile |  57 ++++
>  examples/distributor_app/main.c   | 586 ++++++++++++++++++++++++++++++++++++++
>  examples/distributor_app/main.h   |  46 +++
>  4 files changed, 690 insertions(+)
>  create mode 100644 examples/distributor_app/Makefile
>  create mode 100644 examples/distributor_app/main.c
>  create mode 100644 examples/distributor_app/main.h
> 
> -- 
> 1.8.3.1
>