DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem
@ 2014-09-23 18:53 Wang, Shawn
  2014-09-23 19:12 ` Neil Horman
  2014-09-23 20:03 ` Matthew Hall
  0 siblings, 2 replies; 6+ messages in thread
From: Wang, Shawn @ 2014-09-23 18:53 UTC (permalink / raw)
  To: dev

Hi:

We are using our own Makefile in building dpdk program. Recently we are working on upgrading from DPDK 1.3 to DPDK 1.7. I found the rte_ixgbe_pmd_init has been replaced by PMD_REGISTER_DRIVER. So I delete rte_ixgbe_pmd_init calls. But after that, our dpdk program could not correctly find the NIC anymore. After digging into it a little more, I found the code dose not correctly register the driver type we are using, which is ixgbe.
To isolate the problem, I hacked a smal example l3fwd, and only have the main.c file like this for my testing purpose.

#include <rte_config.h>
#include <rte_eal.h>

#include "main.h"

int
MAIN(int argc, char **argv)
{
        /* init EAL */
        int ret = rte_eal_init(argc, argv);
        printf("ret %d\n", ret);
        return 0;
}

I found if I use the Makefile provided in the example, the program will find the ixgbe NIC. But if I just use these 2 commands to compile and link it. It will not find the ixgbe NIC.

gcc -I../../x86_64-native-linuxapp-gcc/include -L../../x86_64-native-linuxapp-gcc/lib -lrte_eal -c main.c
gcc -o l3fwd main.o -L../../x86_64-native-linuxapp-gcc/lib -lrte_eal -lrte_distributor -lrte_pipeline -lrte_port -lrte_timer -lrte_hash -lrte_acl -lm -lrt -lrte_mbuf -lethdev -lrte_malloc -lrte_mempool -lrte_ring -lc -lm -lrte_cmdline -lrte_cfgfile -lrte_pmd_bond -lrte_pmd_ixgbe -lrte_pmd_e1000 -lrte_pmd_ring -lpthread -ldl -lrt

Can someone share some light on what is magic of the dpdk Makefile to correctly register the NIC type?

Thank you so much.
Xingbo Wang

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem
  2014-09-23 18:53 [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem Wang, Shawn
@ 2014-09-23 19:12 ` Neil Horman
  2014-09-25  8:02   ` Keunhong Lee
  2014-09-23 20:03 ` Matthew Hall
  1 sibling, 1 reply; 6+ messages in thread
From: Neil Horman @ 2014-09-23 19:12 UTC (permalink / raw)
  To: Wang, Shawn; +Cc: dev

On Tue, Sep 23, 2014 at 06:53:57PM +0000, Wang, Shawn wrote:
> Hi:
> 
> We are using our own Makefile in building dpdk program. Recently we are working on upgrading from DPDK 1.3 to DPDK 1.7. I found the rte_ixgbe_pmd_init has been replaced by PMD_REGISTER_DRIVER. So I delete rte_ixgbe_pmd_init calls. But after that, our dpdk program could not correctly find the NIC anymore. After digging into it a little more, I found the code dose not correctly register the driver type we are using, which is ixgbe.
> To isolate the problem, I hacked a smal example l3fwd, and only have the main.c file like this for my testing purpose.
> 
> #include <rte_config.h>
> #include <rte_eal.h>
> 
> #include "main.h"
> 
> int
> MAIN(int argc, char **argv)
> {
>         /* init EAL */
>         int ret = rte_eal_init(argc, argv);
>         printf("ret %d\n", ret);
>         return 0;
> }
> 
> I found if I use the Makefile provided in the example, the program will find the ixgbe NIC. But if I just use these 2 commands to compile and link it. It will not find the ixgbe NIC.
> 
> gcc -I../../x86_64-native-linuxapp-gcc/include -L../../x86_64-native-linuxapp-gcc/lib -lrte_eal -c main.c
> gcc -o l3fwd main.o -L../../x86_64-native-linuxapp-gcc/lib -lrte_eal -lrte_distributor -lrte_pipeline -lrte_port -lrte_timer -lrte_hash -lrte_acl -lm -lrt -lrte_mbuf -lethdev -lrte_malloc -lrte_mempool -lrte_ring -lc -lm -lrte_cmdline -lrte_cfgfile -lrte_pmd_bond -lrte_pmd_ixgbe -lrte_pmd_e1000 -lrte_pmd_ring -lpthread -ldl -lrt
> 
> Can someone share some light on what is magic of the dpdk Makefile to correctly register the NIC type?
> 
> Thank you so much.
> Xingbo Wang
> 

I'm not really sure why you would strip out the Makefiles to dpdk, but I suppose
thats not the germaine question.

First, how are you building the DPDK?  As a set of shared libraries, or as a set
of static archives?  If you're building shared libraries, you need to pass
-shared to gcc, or the constructors will get stripped out using your command
line above.  There might be some other options that escape me, but you can find
out for sure by using the packaged makefiles and running make V=1 to see all the
passed options in the link stage

Secondly, when you say register the NIC type, do you mean that you don't see the
NIC get registered with dpdk, or you don't see an instance of the NIC created?
If its the former, you need to confirm that by running a debugger and looking at
what elements are on the device_list after your applications starts.  If its the
latter, that may well be a config error, as you may need to pass the --whitelist
option on the command line to trigger a device probe.

Neil

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem
  2014-09-23 18:53 [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem Wang, Shawn
  2014-09-23 19:12 ` Neil Horman
@ 2014-09-23 20:03 ` Matthew Hall
  1 sibling, 0 replies; 6+ messages in thread
From: Matthew Hall @ 2014-09-23 20:03 UTC (permalink / raw)
  To: Wang, Shawn; +Cc: dev

On Tue, Sep 23, 2014 at 06:53:57PM +0000, Wang, Shawn wrote:
> Can someone share some light on what is magic of the dpdk Makefile to correctly register the NIC type?

I had the same problem as a guy who began using it before the auto-reg, 
stopped a while, and began again after.

You have to pass the following GNU LD option:

--whole-archive

Matthew.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem
  2014-09-23 19:12 ` Neil Horman
@ 2014-09-25  8:02   ` Keunhong Lee
  0 siblings, 0 replies; 6+ messages in thread
From: Keunhong Lee @ 2014-09-25  8:02 UTC (permalink / raw)
  To: Neil Horman; +Cc: dev

In DPDK1.7, PMDs are loaded by __constructor__ functions.
As there is no direct reference to each PMD driver structures, linker may
not link the PMD library.
You should use -Wl,--whole-archive and -Wl,--no-whole-archive for linking
DPDK applications.
See http://dpdk.org/browse/dpdk/tree/mk/rte.app.mk for further information.

Keunhong.



2014-09-24 4:12 GMT+09:00 Neil Horman <nhorman@tuxdriver.com>:

> On Tue, Sep 23, 2014 at 06:53:57PM +0000, Wang, Shawn wrote:
> > Hi:
> >
> > We are using our own Makefile in building dpdk program. Recently we are
> working on upgrading from DPDK 1.3 to DPDK 1.7. I found the
> rte_ixgbe_pmd_init has been replaced by PMD_REGISTER_DRIVER. So I delete
> rte_ixgbe_pmd_init calls. But after that, our dpdk program could not
> correctly find the NIC anymore. After digging into it a little more, I
> found the code dose not correctly register the driver type we are using,
> which is ixgbe.
> > To isolate the problem, I hacked a smal example l3fwd, and only have the
> main.c file like this for my testing purpose.
> >
> > #include <rte_config.h>
> > #include <rte_eal.h>
> >
> > #include "main.h"
> >
> > int
> > MAIN(int argc, char **argv)
> > {
> >         /* init EAL */
> >         int ret = rte_eal_init(argc, argv);
> >         printf("ret %d\n", ret);
> >         return 0;
> > }
> >
> > I found if I use the Makefile provided in the example, the program will
> find the ixgbe NIC. But if I just use these 2 commands to compile and link
> it. It will not find the ixgbe NIC.
> >
> > gcc -I../../x86_64-native-linuxapp-gcc/include
> -L../../x86_64-native-linuxapp-gcc/lib -lrte_eal -c main.c
> > gcc -o l3fwd main.o -L../../x86_64-native-linuxapp-gcc/lib -lrte_eal
> -lrte_distributor -lrte_pipeline -lrte_port -lrte_timer -lrte_hash
> -lrte_acl -lm -lrt -lrte_mbuf -lethdev -lrte_malloc -lrte_mempool
> -lrte_ring -lc -lm -lrte_cmdline -lrte_cfgfile -lrte_pmd_bond
> -lrte_pmd_ixgbe -lrte_pmd_e1000 -lrte_pmd_ring -lpthread -ldl -lrt
> >
> > Can someone share some light on what is magic of the dpdk Makefile to
> correctly register the NIC type?
> >
> > Thank you so much.
> > Xingbo Wang
> >
>
> I'm not really sure why you would strip out the Makefiles to dpdk, but I
> suppose
> thats not the germaine question.
>
> First, how are you building the DPDK?  As a set of shared libraries, or as
> a set
> of static archives?  If you're building shared libraries, you need to pass
> -shared to gcc, or the constructors will get stripped out using your
> command
> line above.  There might be some other options that escape me, but you can
> find
> out for sure by using the packaged makefiles and running make V=1 to see
> all the
> passed options in the link stage
>
> Secondly, when you say register the NIC type, do you mean that you don't
> see the
> NIC get registered with dpdk, or you don't see an instance of the NIC
> created?
> If its the former, you need to confirm that by running a debugger and
> looking at
> what elements are on the device_list after your applications starts.  If
> its the
> latter, that may well be a config error, as you may need to pass the
> --whitelist
> option on the command line to trigger a device probe.
>
> Neil
>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem
  2014-09-23 21:50 Sanford, Robert
@ 2014-09-23 23:17 ` Wang, Shawn
  0 siblings, 0 replies; 6+ messages in thread
From: Wang, Shawn @ 2014-09-23 23:17 UTC (permalink / raw)
  To: Sanford, Robert, dev

This does resolve the problem.

Thank you so much.

________________________________________
From: Sanford, Robert [rsanford@akamai.com]
Sent: Tuesday, September 23, 2014 2:50 PM
To: Wang, Shawn; dev@dpdk.org
Subject: Re: [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem

We ran into a similar problem when migrating to 1.7.
Here are the subtle flags, in dpdk/mk/rte.app.mk, that we needed:

        LDLIBS += --whole-archive
        ...
        LDLIBS += --no-whole-archive

This apparently tells the linker to pull in whole archive(s), even if it
thinks that we don't need all objects.




--
Regards,
Robert


>Hi:
>
>We are using our own Makefile in building dpdk program. Recently we are
>working on upgrading from DPDK 1.3 to DPDK 1.7. I found the
>rte_ixgbe_pmd_init has been replaced by PMD_REGISTER_DRIVER. So I delete
>rte_ixgbe_pmd_init calls. But after that, our dpdk program could not
>correctly find the NIC anymore. After digging into it a little more, I
>found the code dose not correctly register the driver type we are using,
>which is ixgbe.
>To isolate the problem, I hacked a smal example l3fwd, and only have the
>main.c file like this for my testing purpose.
>
>#include <rte_config.h>
>#include <rte_eal.h>
>
>#include "main.h"
>
>int
>MAIN(int argc, char **argv)
>{
>        /* init EAL */
>        int ret = rte_eal_init(argc, argv);
>        printf("ret %d\n", ret);
>        return 0;
>}
>
>I found if I use the Makefile provided in the example, the program will
>find the ixgbe NIC. But if I just use these 2 commands to compile and
>link it. It will not find the ixgbe NIC.
>
>gcc -I../../x86_64-native-linuxapp-gcc/include
>-L../../x86_64-native-linuxapp-gcc/lib -lrte_eal -c main.c
>gcc -o l3fwd main.o -L../../x86_64-native-linuxapp-gcc/lib -lrte_eal
>-lrte_distributor -lrte_pipeline -lrte_port -lrte_timer -lrte_hash
>-lrte_acl -lm -lrt -lrte_mbuf -lethdev -lrte_malloc -lrte_mempool
>-lrte_ring -lc -lm -lrte_cmdline -lrte_cfgfile -lrte_pmd_bond
>-lrte_pmd_ixgbe -lrte_pmd_e1000 -lrte_pmd_ring -lpthread -ldl -lrt
>
>Can someone share some light on what is magic of the dpdk Makefile to
>correctly register the NIC type?
>
>Thank you so much.
>Xingbo Wang


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem
@ 2014-09-23 21:50 Sanford, Robert
  2014-09-23 23:17 ` Wang, Shawn
  0 siblings, 1 reply; 6+ messages in thread
From: Sanford, Robert @ 2014-09-23 21:50 UTC (permalink / raw)
  To: Wang, Shawn, dev

We ran into a similar problem when migrating to 1.7.
Here are the subtle flags, in dpdk/mk/rte.app.mk, that we needed:

	LDLIBS += --whole-archive
	...
	LDLIBS += --no-whole-archive

This apparently tells the linker to pull in whole archive(s), even if it
thinks that we don't need all objects.




--
Regards,
Robert


>Hi:
>
>We are using our own Makefile in building dpdk program. Recently we are
>working on upgrading from DPDK 1.3 to DPDK 1.7. I found the
>rte_ixgbe_pmd_init has been replaced by PMD_REGISTER_DRIVER. So I delete
>rte_ixgbe_pmd_init calls. But after that, our dpdk program could not
>correctly find the NIC anymore. After digging into it a little more, I
>found the code dose not correctly register the driver type we are using,
>which is ixgbe.
>To isolate the problem, I hacked a smal example l3fwd, and only have the
>main.c file like this for my testing purpose.
>
>#include <rte_config.h>
>#include <rte_eal.h>
>
>#include "main.h"
>
>int
>MAIN(int argc, char **argv)
>{
>        /* init EAL */
>        int ret = rte_eal_init(argc, argv);
>        printf("ret %d\n", ret);
>        return 0;
>}
>
>I found if I use the Makefile provided in the example, the program will
>find the ixgbe NIC. But if I just use these 2 commands to compile and
>link it. It will not find the ixgbe NIC.
>
>gcc -I../../x86_64-native-linuxapp-gcc/include
>-L../../x86_64-native-linuxapp-gcc/lib -lrte_eal -c main.c
>gcc -o l3fwd main.o -L../../x86_64-native-linuxapp-gcc/lib -lrte_eal
>-lrte_distributor -lrte_pipeline -lrte_port -lrte_timer -lrte_hash
>-lrte_acl -lm -lrt -lrte_mbuf -lethdev -lrte_malloc -lrte_mempool
>-lrte_ring -lc -lm -lrte_cmdline -lrte_cfgfile -lrte_pmd_bond
>-lrte_pmd_ixgbe -lrte_pmd_e1000 -lrte_pmd_ring -lpthread -ldl -lrt
>
>Can someone share some light on what is magic of the dpdk Makefile to
>correctly register the NIC type?
>
>Thank you so much.
>Xingbo Wang

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-09-25  7:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-23 18:53 [dpdk-dev] Can not init NIC after merge to DPDK 1.7 problem Wang, Shawn
2014-09-23 19:12 ` Neil Horman
2014-09-25  8:02   ` Keunhong Lee
2014-09-23 20:03 ` Matthew Hall
2014-09-23 21:50 Sanford, Robert
2014-09-23 23:17 ` Wang, Shawn

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git