From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 533F268A2
 for <dev@dpdk.org>; Sun, 28 Sep 2014 03:49:04 +0200 (CEST)
Received: from [2001:470:8:a08:215:ff:fecc:4872] (helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1XY3hj-0008Ex-JF; Sat, 27 Sep 2014 21:55:31 -0400
Date: Sat, 27 Sep 2014 21:55:04 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: "Wiles, Roger Keith" <keith.wiles@windriver.com>
Message-ID: <20140928015504.GA28263@localhost.localdomain>
References: <DAE811FA-C1F1-444D-980C-311BCCE7FF3C@windriver.com>
 <20140928003719.GA27849@localhost.localdomain>
 <A4B5A27D-D8B1-4391-907A-C6262A13FDC6@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A4B5A27D-D8B1-4391-907A-C6262A13FDC6@windriver.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: "<dev@dpdk.org>" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] rte_mempool_dump() crashes with NULL
 rte_mempool pointer.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Sep 2014 01:49:04 -0000

On Sun, Sep 28, 2014 at 01:14:05AM +0000, Wiles, Roger Keith wrote:
> 
> On Sep 27, 2014, at 7:37 PM, Neil Horman <nhorman@tuxdriver.com> wrote:
> 
> > On Sat, Sep 27, 2014 at 06:35:01PM +0000, Wiles, Roger Keith wrote:
> >> 
> >> Check the FILE *f and rte_mempool *mp pointers for NULL and
> >> return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled.
> >> 
> >> Signed-off-by: Keith Wiles <keith.wiles@windriver.com>
> >> ---
> >> lib/librte_mempool/rte_mempool.c | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >> 
> >> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
> >> index 332f469..efa6a6c 100644
> >> --- a/lib/librte_mempool/rte_mempool.c
> >> +++ b/lib/librte_mempool/rte_mempool.c
> >> @@ -765,6 +765,12 @@ rte_mempool_dump(FILE *f, const struct rte_mempool *mp)
> >>    unsigned common_count;
> >>    unsigned cache_count;
> >> 
> >> +   if ( (f == NULL) || (mp == NULL) ) {
> >> +#ifdef RTE_LIBRTE_MEMPOOL_DEBUG
> >> +       fprintf(stderr, "*** Called rte_mempool_dump(%p, %p) with NULL argument\n", f, mp);
> >> +#endif /* RTE_LIBRTE_MEMPOOL_DEBUG */
> >> +       return;
> >> +   }
> >>    fprintf(f, "mempool <%s>@%p\n", mp->name, mp);
> >>    fprintf(f, "  flags=%x\n", mp->flags);
> >>    fprintf(f, "  ring=<%s>@%p\n", mp->ring->name, mp->ring);
> >> -- 
> >> 2.1.0
> >> 
> >> 
> > Maybe use RTE_VERIFY instead?
> > Neil
> > 
> I did not think it needs to panic as it is just a debug function and returning would be fine by me, comments?
> Do we have a similar RTE_VERIFY like function that does not panic?
> 
If we don't, it would seem useful to make one.  It beats having to do specific
condition checking/error reporting.  RTE_VERIFY_WARN or some such.
Neil

> Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
> 
>