From: Neil Horman <nhorman@tuxdriver.com>
To: Ding Heng <hengx.ding@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: The users could get device types now
Date: Sun, 28 Sep 2014 08:36:40 -0400 [thread overview]
Message-ID: <20140928123640.GC30445@localhost.localdomain> (raw)
In-Reply-To: <1411874836-3274-1-git-send-email-hengx.ding@intel.com>
On Sun, Sep 28, 2014 at 11:27:16AM +0800, Ding Heng wrote:
> As different PMDs support different features, application may want
> to know the NIC type of a port, then decide how to use that port.
> Add a new field in struct rte_eth_dev, users are able to get
> device type now.
>
> Signed-off-by: Ding Heng <hengx.ding@intel.com>
Nack. This patch embodies PMD specific information in a common library, which
really isn't necessecary. It implies that developers who maintain PMDs outside
of the core dpdk still need to do some maintenence in the core for all the dpdk
features to work. Its also a layering violation. The core shouldn't have to
know any specifics about a driver to initalize it, even its name.
If an application wants to know what type of driver a NIC is,
the application can just interrogate the pci drivers name field directly.
Neil
next prev parent reply other threads:[~2014-09-28 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 3:27 Ding Heng
2014-09-28 3:50 ` Zhang, Helin
2014-09-28 12:36 ` Neil Horman [this message]
2014-09-29 3:06 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928123640.GC30445@localhost.localdomain \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=hengx.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).