From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 567557E1B for ; Mon, 29 Sep 2014 12:59:23 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 29 Sep 2014 04:05:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="392975320" Received: from bricha3-mobl.ger.corp.intel.com (HELO bricha3-mobl.ir.intel.com) ([10.243.20.21]) by FMSMGA003.fm.intel.com with SMTP; 29 Sep 2014 03:59:09 -0700 Received: by bricha3-mobl.ir.intel.com (sSMTP sendmail emulation); Mon, 29 Sep 2014 12:05:22 +0001 Date: Mon, 29 Sep 2014 12:05:22 +0100 From: Bruce Richardson To: Chao Zhu Message-ID: <20140929110522.GF12072@BRICHA3-MOBL> References: <1411724018-7738-1-git-send-email-bjzhuc@cn.ibm.com> <1411724018-7738-2-git-send-email-bjzhuc@cn.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411724018-7738-2-git-send-email-bjzhuc@cn.ibm.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.22 (2013-10-16) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/7] Split atomic operations to architecture specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2014 10:59:23 -0000 On Fri, Sep 26, 2014 at 05:33:32AM -0400, Chao Zhu wrote: > This patch splits the atomic operations from DPDK and push them to > architecture specific arch directories, so that other processor > architecture to support DPDK can be easily adopted. > > Signed-off-by: Chao Zhu > --- > lib/librte_eal/common/Makefile | 2 +- > .../common/include/i686/arch/rte_atomic_arch.h | 378 ++++++++++++++++++++ > lib/librte_eal/common/include/rte_atomic.h | 172 +-------- > .../common/include/x86_64/arch/rte_atomic_arch.h | 378 ++++++++++++++++++++ > 4 files changed, 772 insertions(+), 158 deletions(-) > create mode 100644 lib/librte_eal/common/include/i686/arch/rte_atomic_arch.h > create mode 100644 lib/librte_eal/common/include/x86_64/arch/rte_atomic_arch.h > <...snip...> > +#define rte_compiler_barrier() rte_arch_compiler_barrier() Small question: shouldn't the compiler barrier be independent of architecture? /Bruce