From: Neil Horman <nhorman@tuxdriver.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Chao Zhu <bjzhuc@cn.ibm.com>
Subject: Re: [dpdk-dev] [PATCH 1/7] Split atomic operations to architecture specific
Date: Mon, 29 Sep 2014 11:24:09 -0400 [thread overview]
Message-ID: <20140929152409.GF26483@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20140929110522.GF12072@BRICHA3-MOBL>
On Mon, Sep 29, 2014 at 12:05:22PM +0100, Bruce Richardson wrote:
> On Fri, Sep 26, 2014 at 05:33:32AM -0400, Chao Zhu wrote:
> > This patch splits the atomic operations from DPDK and push them to
> > architecture specific arch directories, so that other processor
> > architecture to support DPDK can be easily adopted.
> >
> > Signed-off-by: Chao Zhu <bjzhuc@cn.ibm.com>
> > ---
> > lib/librte_eal/common/Makefile | 2 +-
> > .../common/include/i686/arch/rte_atomic_arch.h | 378 ++++++++++++++++++++
> > lib/librte_eal/common/include/rte_atomic.h | 172 +--------
> > .../common/include/x86_64/arch/rte_atomic_arch.h | 378 ++++++++++++++++++++
> > 4 files changed, 772 insertions(+), 158 deletions(-)
> > create mode 100644 lib/librte_eal/common/include/i686/arch/rte_atomic_arch.h
> > create mode 100644 lib/librte_eal/common/include/x86_64/arch/rte_atomic_arch.h
> >
> <...snip...>
> > +#define rte_compiler_barrier() rte_arch_compiler_barrier()
>
> Small question: shouldn't the compiler barrier be independent of
> architecture?
>
Agreed, compiler intrinsics I thought were used to define barriers, regardless
of arch (__memory_barrier() is the gcc intrinsic IIRC)
Neil
> /Bruce
>
>
next prev parent reply other threads:[~2014-09-29 15:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 9:33 [dpdk-dev] [PATCH 0/7] Patches to split architecture specific operations from DPDK Chao Zhu
2014-09-26 9:33 ` [dpdk-dev] [PATCH 1/7] Split atomic operations to architecture specific Chao Zhu
2014-09-29 11:05 ` Bruce Richardson
2014-09-29 15:24 ` Neil Horman [this message]
2014-09-30 2:18 ` Chao CH Zhu
2014-09-26 9:33 ` [dpdk-dev] [PATCH 2/7] Split byte order " Chao Zhu
2014-09-26 9:33 ` [dpdk-dev] [PATCH 3/7] Split CPU cycle operation " Chao Zhu
2014-09-26 9:33 ` [dpdk-dev] [PATCH 4/7] Split prefetch operations " Chao Zhu
2014-09-26 9:33 ` [dpdk-dev] [PATCH 5/7] Split spinlock " Chao Zhu
2014-09-26 9:33 ` [dpdk-dev] [PATCH 6/7] Split memcpy operation " Chao Zhu
2014-09-26 9:33 ` [dpdk-dev] [PATCH 7/7] Split CPU flags operations " Chao Zhu
2014-10-03 13:21 ` [dpdk-dev] [PATCH 0/7] Patches to split architecture specific operations from DPDK David Marchand
2014-10-03 13:29 ` Bruce Richardson
2014-10-13 2:36 ` Chao CH Zhu
2014-10-06 21:46 ` Cyril Chemparathy
2014-10-12 9:14 ` Chao CH Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929152409.GF26483@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=bjzhuc@cn.ibm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).