From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5F976106A for ; Wed, 1 Oct 2014 18:00:47 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 01 Oct 2014 09:06:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,633,1406617200"; d="scan'208";a="608223404" Received: from bricha3-mobl.ger.corp.intel.com (HELO bricha3-mobl.ir.intel.com) ([10.243.20.27]) by fmsmga002.fm.intel.com with SMTP; 01 Oct 2014 09:05:50 -0700 Received: by bricha3-mobl.ir.intel.com (sSMTP sendmail emulation); Wed, 01 Oct 2014 17:05:48 +0001 Date: Wed, 1 Oct 2014 17:05:48 +0100 From: Bruce Richardson To: Neil Horman Message-ID: <20141001160548.GA6676@BRICHA3-MOBL> References: <05E7C1C5-2730-4BE3-B808-6F69821F7898@windriver.com> <20140928122706.GB30445@localhost.localdomain> <8437457.lrG762lvxy@xps13> <20141001150227.GC24028@localhost.localdomain> <20141001154310.GB9292@BRICHA3-MOBL> <20141001160109.GE24028@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141001160109.GE24028@localhost.localdomain> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.22 (2013-10-16) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2014 16:00:47 -0000 On Wed, Oct 01, 2014 at 12:01:10PM -0400, Neil Horman wrote: > On Wed, Oct 01, 2014 at 04:43:10PM +0100, Bruce Richardson wrote: > > On Wed, Oct 01, 2014 at 11:02:27AM -0400, Neil Horman wrote: > > > On Wed, Oct 01, 2014 at 03:36:45PM +0200, Thomas Monjalon wrote: > > > > 2014-09-28 08:27, Neil Horman: > > > > > On Sun, Sep 28, 2014 at 05:28:44AM +0000, Wiles, Roger Keith wrote: > > > > > > Check the FILE *f and rte_mempool *mp pointers for NULL and > > > > > > return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled. > > > > > > > > > > > > Signed-off-by: Keith Wiles > > > > > > > > > > I'm fine with this, as I think passing in a NULL mempool is clearly a bug here, > > > > > thats worth panicing over, though I wouldnt mind if we did a RTE_VERIFY_WARN > > > > > macro here instead using what I suggested in my other note > > > > > > > > Passing a NULL mempool to rte_mempool_dump() is a bug in the application. > > > > If you look elsewhere in the DPDK code, you'll see that it's not common to do > > > > such check on input parameters. > > > > A similar discussion already happened few months ago: > > > > http://dpdk.org/ml/archives/dev/2014-June/003900.html > > > > > > > Not sure what your point is here Thomas. I think we're all in agreement that > > > NULL is a bad value to pass in here. Are you asserting that we shouldn't bother > > > with a NULL check at all and just accept the crash as it is? > > > > > > > In the general case: > > * Code in the datapath should not have things like NULL checks > > * However, datapath code should generally have a debug option which turns > > these checks on to help debugging if needed. > > * Code not in the datapath probably should have these checks. > > > Ok, I can understand that, but I would hope that rte_mempool_dump isn't in the > datapath, its rather by definition a debug function, isn't it? > Neil Yes, agreed. [So it probably should have the NULL check]. /Bruce