From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 71514106A for ; Wed, 1 Oct 2014 18:01:15 +0200 (CEST) Received: from nat-pool-rdu-u.redhat.com ([66.187.233.203] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1XZMRV-0001WL-JY; Wed, 01 Oct 2014 12:07:58 -0400 Date: Wed, 1 Oct 2014 12:07:46 -0400 From: Neil Horman To: Bruce Richardson Message-ID: <20141001160746.GF24028@localhost.localdomain> References: <1411568210-2555-1-git-send-email-reshma.pattan@intel.com> <1412073577-12248-1-git-send-email-reshma.pattan@intel.com> <20140930113445.GB2193@hmsreliant.think-freely.org> <20140930121828.GA9312@BRICHA3-MOBL> <20140930133958.GG2193@hmsreliant.think-freely.org> <3AEA2BF9852C6F48A459DA490692831FE20FB6@IRSMSX109.ger.corp.intel.com> <20141001145620.GB24028@localhost.localdomain> <20141001153730.GA9292@BRICHA3-MOBL> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141001153730.GA9292@BRICHA3-MOBL> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3] distributor_app: new sample app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2014 16:01:15 -0000 > > > > > > 1)I had sent v5 patch which handles graceful shutdown of rx and tx threads upon SIGINT > > I see it and will take a look shortly, thanks. > > > > > 2)Worker thread graceful shutdown was not handled as of now as it needs some change in lcore_worker logic , which will be done in future enhancements. > > Not sure I understand what you mean here. Can you elaborate? > > > > > 3)Freeing of mempool is also not handled , as the framework support is not available. > > Ew, I hadn't noticed that, freeing of mempools seems like something we should > > implement. > > > > > 4)Cleaning of rx/tx queues not done, as it needs some extensive logic which we haven't planned as of now. Will check the possibility of doing it in future enhancements i.e in next version of sample application. > > We can't just flush the queues after we shutdown the workers? I presume a queue > > flush operation exists, yes? > > Neil > > Other than code hygiene, which does have some value in itself, I can't > really see what the practical point of such cleanup would be. > This is really the only assertion I'm trying to make. I understand this application won't suffer from exiting uncleanly, and that makes the need for preforming cleanup little more than overhead. But that said, hygine is exactly the point I'm driving at here. These are example applications, that presumably people look at when writing their own apps. If you don't do things properly, people looking at your code are less likely to do them as well. Even if it doesn't hurt for you to exit uncleanly, it will hurt someone, and if they look to these examples as a source of best practices, it seems to me that it would be in everyones interest, if best practices were demonstrated. Neil