From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mhall@mhcomputing.net>
Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])
 by dpdk.org (Postfix) with ESMTP id 62DEAE82
 for <dev@dpdk.org>; Fri,  3 Oct 2014 19:54:11 +0200 (CEST)
Received: by mail.mhcomputing.net (Postfix, from userid 1000)
 id B8F2B80B615; Fri,  3 Oct 2014 11:00:22 -0700 (PDT)
Date: Fri, 3 Oct 2014 11:00:22 -0700
From: Matthew Hall <mhall@mhcomputing.net>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20141003180022.GA1741@mhcomputing.net>
References: <1412265386-26291-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <20141002172634.GE4900@hmsreliant.think-freely.org>
 <20141002200420.GB29590@mhcomputing.net> <2041475.WSUx3LgNfR@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2041475.WSUx3LgNfR@xps13>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/4] Fix build issues with
 CONFIG_RTE_BUILD_COMBINE_LIBS=y
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Oct 2014 17:54:11 -0000

On Fri, Oct 03, 2014 at 09:15:20AM +0200, Thomas Monjalon wrote:
> We need to simplify build options. So I'm fine to remove COMBINE_LIBS option
> to always enable it.
> About making only one single static library, I think it's a good idea if
> it brings a real code simplification.
> 
> So the conclusion is to nack this patchset in favor of above changes.
> Sergio, comments?

It works for me... I love COMBINE_LIBS... but it won't be necessarily backward 
compatible with people already linking against existing DPDK. Hence why I 
proposed just always building the per-feature static libs and always building 
the combined lib rather than forcing people to do one or the other.

Also different people might have different configs where they link in greater 
or fewer or different PMD's or features in different configs of their build... 
they might be annoyed if their separate libs disappear.

Matthew.