DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: "Nicolás Pernas Maradei" <nico@emutex.com>,
	f@hmsreliant.think-freely.org
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] Fix librte_pmd_pcap driver double stop error
Date: Mon, 6 Oct 2014 10:50:20 -0400	[thread overview]
Message-ID: <20141006145020.GE22304@hmsreliant.think-freely.org> (raw)
In-Reply-To: <209a96ce6067cf0b5239b8d9143fbb2a@statler.emutex.com>

On Sun, Oct 05, 2014 at 07:37:11PM +0100, Nicolás Pernas Maradei wrote:
> Hi,
> 
> New in Patch v2:
> 
> - Fixes an issue in eth_dev_start/stop where a single interface was always
> opened/closed even though pcap files had been selected for rx/tx streams.
> - The link_status was not being properly updated in case of using a single
> interface for rx/tx streams.
> 
> Nico.
> 
> On 2014-10-04 23:24, Nicolás Pernas Maradei wrote:
> >From: Nicolás Pernas Maradei <nicolas.pernas.maradei@emutex.com>
> >
> >librte_pmd_pcap driver was opening the pcap/interfaces only at init time
> >and
> >closing them only when the port was being stopped. This behaviour would
> >cause
> >problems (leading to segfault) if the user closed the port 2 times. The
> >first
> >time the pcap/interfaces would be normally closed but libpcap would throw
> >an
> >error causing a segfault if the closed pcaps/interfaces were closed again.
> >This behaviour is solved by re-openning pcaps/interfaces when the port is
> >started (only if these weren't open already for example at init time).
> >
> >Signed-off-by: Nicolás Pernas Maradei <nico@emutex.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>

  reply	other threads:[~2014-10-06 14:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <005307>
2014-10-04 22:24 ` Nicolás Pernas Maradei
2014-10-05 18:37   ` Nicolás Pernas Maradei
2014-10-06 14:50     ` Neil Horman [this message]
2014-10-09 19:10       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141006145020.GE22304@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=dev@dpdk.org \
    --cc=f@hmsreliant.think-freely.org \
    --cc=nico@emutex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).