From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5BF6568CD for ; Mon, 6 Oct 2014 16:54:53 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by fmsmga101.fm.intel.com with ESMTP; 06 Oct 2014 08:02:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,664,1406617200"; d="scan'208";a="482263646" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by azsmga001.ch.intel.com with ESMTP; 06 Oct 2014 08:01:38 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id s96F1Zlk032672; Mon, 6 Oct 2014 16:01:35 +0100 Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id s96F1ZnR021536; Mon, 6 Oct 2014 16:01:35 +0100 Received: (from smonroy@localhost) by sivswdev02.ir.intel.com with id s96F1X9I020977; Mon, 6 Oct 2014 16:01:33 +0100 Date: Mon, 6 Oct 2014 16:01:33 +0100 From: Sergio Gonzalez Monroy To: Neil Horman Message-ID: <20141006150133.GA778@sivswdev02.ir.intel.com> References: <1412265386-26291-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1412592755-3370-1-git-send-email-sergio.gonzalez.monroy@intel.com> <20141006144946.GD22304@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141006144946.GD22304@hmsreliant.think-freely.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/4] Update build process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Oct 2014 14:54:53 -0000 On Mon, Oct 06, 2014 at 10:49:46AM -0400, Neil Horman wrote: > On Mon, Oct 06, 2014 at 11:52:31AM +0100, Sergio Gonzalez Monroy wrote: > > As per the proposal, this patch set does: > > - Remove CONFIG_RTE_BUILD_COMBINE_LIBS as a configuration option. > > - For static library, build a single/combined library. > > - For shared libraries, build both individual/separated and single/combined > > libraries. > > - Link apps only against single/combined libs. > > > > > > Sergio Gonzalez Monroy (4): > > Link combined shared library using CC > > Link apps only against single/combined library > > Update library build process > > Link apps/DSOs against EXECENV_LDLIBS with --as-needed > > > > config/common_bsdapp | 3 +- > > config/common_linuxapp | 3 +- > > mk/rte.app.mk | 164 ++----------------------------------------------- > > mk/rte.lib.mk | 81 ++++++------------------ > > mk/rte.sdkbuild.mk | 2 +- > > mk/rte.sharelib.mk | 54 ++++++++-------- > > mk/rte.vars.mk | 4 -- > > 7 files changed, 54 insertions(+), 257 deletions(-) > > > > -- > > 1.9.3 > > > > > > I see you removed the --whole-archive option when building the single library > here. Have you checked to make sure that all the constructors haven't been > stripped out? I am not entirely sure I follow. There is no --whole-archive when building libraries, at least not in my sources. The flag is used when linking apps and I have not removed it as you can see on patch 2/4. Sergio > Neil >