From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id E5FE2959 for ; Mon, 6 Oct 2014 17:59:02 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1XbAnF-0001xi-5B; Mon, 06 Oct 2014 12:06:08 -0400 Date: Mon, 6 Oct 2014 12:05:48 -0400 From: Neil Horman To: Sergio Gonzalez Monroy Message-ID: <20141006160548.GF22304@hmsreliant.think-freely.org> References: <1412265386-26291-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1412592755-3370-1-git-send-email-sergio.gonzalez.monroy@intel.com> <20141006144946.GD22304@hmsreliant.think-freely.org> <20141006150133.GA778@sivswdev02.ir.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141006150133.GA778@sivswdev02.ir.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/4] Update build process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Oct 2014 15:59:03 -0000 On Mon, Oct 06, 2014 at 04:01:33PM +0100, Sergio Gonzalez Monroy wrote: > On Mon, Oct 06, 2014 at 10:49:46AM -0400, Neil Horman wrote: > > On Mon, Oct 06, 2014 at 11:52:31AM +0100, Sergio Gonzalez Monroy wrote: > > > As per the proposal, this patch set does: > > > - Remove CONFIG_RTE_BUILD_COMBINE_LIBS as a configuration option. > > > - For static library, build a single/combined library. > > > - For shared libraries, build both individual/separated and single/combined > > > libraries. > > > - Link apps only against single/combined libs. > > > > > > > > > Sergio Gonzalez Monroy (4): > > > Link combined shared library using CC > > > Link apps only against single/combined library > > > Update library build process > > > Link apps/DSOs against EXECENV_LDLIBS with --as-needed > > > > > > config/common_bsdapp | 3 +- > > > config/common_linuxapp | 3 +- > > > mk/rte.app.mk | 164 ++----------------------------------------------- > > > mk/rte.lib.mk | 81 ++++++------------------ > > > mk/rte.sdkbuild.mk | 2 +- > > > mk/rte.sharelib.mk | 54 ++++++++-------- > > > mk/rte.vars.mk | 4 -- > > > 7 files changed, 54 insertions(+), 257 deletions(-) > > > > > > -- > > > 1.9.3 > > > > > > > > > > I see you removed the --whole-archive option when building the single library > > here. Have you checked to make sure that all the constructors haven't been > > stripped out? > > I am not entirely sure I follow. There is no --whole-archive when building libraries, > at least not in my sources. > The flag is used when linking apps and I have not removed it as you can see on patch 2/4. > > Sergio You're right, I saw in one of your patches --whole-archive, but it was context, not actual change, sorry Neil > > > Neil > > >