DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/bsd: fix core detection
Date: Wed, 8 Oct 2014 06:53:55 -0400	[thread overview]
Message-ID: <20141008105355.GA5045@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1412757811-10625-1-git-send-email-david.marchand@6wind.com>

On Wed, Oct 08, 2014 at 10:43:31AM +0200, David Marchand wrote:
> Following "options parsing" patchset (commit d7cb626f and 489a9d6c), core
> detection is not working correctly on bsd.
> 
> ./x86_64-native-bsdapp-gcc/app/test -c f -n 4 -- -i
> [...]
> EAL: lcore 0 unavailable
> EAL: invalid coremask
> 
> Align bsd to linux:
> - commit f563a372 "eal: fix recording of detected/enabled logical cores"
> - commit 4f04db8b "eal: check coremask against detected lcores"
> 
> Reported-by: Zhan, Zhaochen <zhaochen.zhan@intel.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>

Acked-by: Neil Horman <nhorman@tuxdriver.com>

Though, that said, why are these files diverged in the first place?  At least as
far as eal_lcore.c and eal.c are concerned the only differences appear to be
cases of one file being updated and not the other.  It seems that, rather than
doing a patch like this to bring bsd up to date with linux, we should just
de-dup the files, put them in a common location and handle any real behavioral
differences with macros/ifdefs.  Is there a reason for separating them?

Neil

  parent reply	other threads:[~2014-10-08 10:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08  8:43 David Marchand
2014-10-08  9:20 ` Bruce Richardson
2014-10-08 10:10   ` Zhan, Zhaochen
2014-10-09 18:24     ` Thomas Monjalon
2014-10-08 10:53 ` Neil Horman [this message]
2014-10-08 11:23   ` David Marchand
2014-10-08 19:17     ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141008105355.GA5045@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).