DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] Modify tools/setup.sh to be compatible with fedora 21
@ 2014-10-08 13:11 Daniel Mrzyglod
  2014-10-08 13:58 ` Mrzyglod, DanielX T
  2014-10-08 14:36 ` Neil Horman
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Mrzyglod @ 2014-10-08 13:11 UTC (permalink / raw)
  To: dev; +Cc: Daniel Mrzyglod

From: Daniel Mrzyglod <dtmrzglx@localhost.localdomain>

script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
there are Compressed kernel modules - xz (LZMA)

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 tools/setup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/setup.sh b/tools/setup.sh
index 369e09e..6a9d23c 100755
--- a/tools/setup.sh
+++ b/tools/setup.sh
@@ -169,7 +169,7 @@ load_igb_uio_module()
 
 	/sbin/lsmod | grep -s uio > /dev/null
 	if [ $? -ne 0 ] ; then
-		if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
+		if ls /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko* &> /dev/null; then
 			echo "Loading uio module"
 			sudo /sbin/modprobe uio
 		fi
-- 
2.1.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] Modify tools/setup.sh to be compatible with fedora 21
  2014-10-08 13:11 [dpdk-dev] [PATCH] Modify tools/setup.sh to be compatible with fedora 21 Daniel Mrzyglod
@ 2014-10-08 13:58 ` Mrzyglod, DanielX T
  2014-10-08 14:36 ` Neil Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Mrzyglod, DanielX T @ 2014-10-08 13:58 UTC (permalink / raw)
  To: dev

Section From: should be 
From: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>. 

error due to setting fedora 21 alpha on the new machine
> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Wednesday, October 08, 2014 3:12 PM
> To: dev@dpdk.org
> Cc: Daniel Mrzyglod; Mrzyglod, DanielX T
> Subject: [PATCH] Modify tools/setup.sh to be compatible with fedora 21
> 
> From: Daniel Mrzyglod <dtmrzglx@localhost.localdomain>
> 
> script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in
> fedora 21
> there are Compressed kernel modules - xz (LZMA)
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>  tools/setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/setup.sh b/tools/setup.sh
> index 369e09e..6a9d23c 100755
> --- a/tools/setup.sh
> +++ b/tools/setup.sh
> @@ -169,7 +169,7 @@ load_igb_uio_module()
> 
>  	/sbin/lsmod | grep -s uio > /dev/null
>  	if [ $? -ne 0 ] ; then
> -		if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ;
> then
> +		if ls /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko* &>
> /dev/null; then
>  			echo "Loading uio module"
>  			sudo /sbin/modprobe uio
>  		fi
> --
> 2.1.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] Modify tools/setup.sh to be compatible with fedora 21
  2014-10-08 13:11 [dpdk-dev] [PATCH] Modify tools/setup.sh to be compatible with fedora 21 Daniel Mrzyglod
  2014-10-08 13:58 ` Mrzyglod, DanielX T
@ 2014-10-08 14:36 ` Neil Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Neil Horman @ 2014-10-08 14:36 UTC (permalink / raw)
  To: Daniel Mrzyglod; +Cc: dev, Daniel Mrzyglod

On Wed, Oct 08, 2014 at 02:11:31PM +0100, Daniel Mrzyglod wrote:
> From: Daniel Mrzyglod <dtmrzglx@localhost.localdomain>
> 
> script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
> there are Compressed kernel modules - xz (LZMA)
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>  tools/setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/setup.sh b/tools/setup.sh
> index 369e09e..6a9d23c 100755
> --- a/tools/setup.sh
> +++ b/tools/setup.sh
> @@ -169,7 +169,7 @@ load_igb_uio_module()
>  
>  	/sbin/lsmod | grep -s uio > /dev/null
>  	if [ $? -ne 0 ] ; then
> -		if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
> +		if ls /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko* &> /dev/null; then
>  			echo "Loading uio module"
>  			sudo /sbin/modprobe uio
>  		fi
> -- 
> 2.1.0
> 
> 

Just use modinfo uio and test the exit code.  That will make the setup script
agnostic to both filename extension and to kernel version, as modinfo looks in
the running kernel path automatically

Neil

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-08 14:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-08 13:11 [dpdk-dev] [PATCH] Modify tools/setup.sh to be compatible with fedora 21 Daniel Mrzyglod
2014-10-08 13:58 ` Mrzyglod, DanielX T
2014-10-08 14:36 ` Neil Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).