Re: [dpdk-dev] [PATCH] eal/bsd: fix core detection

[Neil Horman <nhorman@tuxdriver.com>]

On Wed, Oct 08, 2014 at 01:23:49PM +0200, David Marchand wrote:
> Hello Neil,
> 
> On Wed, Oct 8, 2014 at 12:53 PM, Neil Horman <nhorman@tuxdriver.com> wrote:
> >
> > Though, that said, why are these files diverged in the first place?  At
> > least as
> > far as eal_lcore.c and eal.c are concerned the only differences appear to
> > be
> > cases of one file being updated and not the other.  It seems that, rather
> > than
> > doing a patch like this to bring bsd up to date with linux, we should just
> > de-dup the files, put them in a common location and handle any real
> > behavioral
> > differences with macros/ifdefs.  Is there a reason for separating them?
> >
> 
> I agree that there should only be one file for those things (and a lot of
> other stuff like eal_debug, eal_log etc...).
> This is not that easy: I tried once and gave up because the resulting
> patchset was huge.
> Personally, I don't have time to dig into this.
> 
No one ever does, thats how messes like this happen :)

I've got a bsd guest installed, I'll see if I can clean it up.
Neil

> 
> -- 
> David Marchand