From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <smonroy@ecsmtp.ir.intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 63AEE7E71
 for <dev@dpdk.org>; Thu,  9 Oct 2014 11:30:08 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 09 Oct 2014 02:34:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,683,1406617200"; d="scan'208";a="585919902"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by orsmga001.jf.intel.com with ESMTP; 09 Oct 2014 02:37:15 -0700
Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com
 [10.237.217.46])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 s999bE3d029163; Thu, 9 Oct 2014 10:37:14 +0100
Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1])
 by sivswdev02.ir.intel.com with ESMTP id s999bEeE003213;
 Thu, 9 Oct 2014 10:37:14 +0100
Received: (from smonroy@localhost)
 by sivswdev02.ir.intel.com with  id s999bDvI003209;
 Thu, 9 Oct 2014 10:37:13 +0100
Date: Thu, 9 Oct 2014 10:37:13 +0100
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20141009093713.GB23978@sivswdev02.ir.intel.com>
References: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1731940.NUuDDJsRCL@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1731940.NUuDDJsRCL@xps13>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Oct 2014 09:30:08 -0000

On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote:
> Hi Sergio,
> 
> 2014-10-06 17:09, Sergio Gonzalez Monroy:
> > --- a/mk/rte.module.mk
> > +++ b/mk/rte.module.mk
> > @@ -78,7 +78,7 @@ build: _postbuild
> >  $(MODULE).ko: $(SRCS_LINKS)
> >  	@if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
> >  	@$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
> > -		CROSS_COMPILE=$(CROSS)
> > +		V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS)
> 
> Please could you explain why it is needed?
> The variable V should be inherited by the recursive make.
> It's working without your patch in my test.
> 
Hi Thomas,

You are right. If you set V=1 in the commmand line it will inherit and pass it down.
In the curent framework, we do not force V to be 1, just to be defined (coud be V=y
or V=enable, etc).
This patch was just forcing the value to be 1 as it is the required value for the
kernel makefiles.

It is not a big deal and we could approach this by specifiying on the docs to be V=1
or any other way you think more appropiate?

Thanks,
Sergio

> -- 
> Thomas