From: Neil Horman <nhorman@tuxdriver.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] Modify tools/setup.sh to be compatible with fedora 21
Date: Thu, 9 Oct 2014 12:39:42 -0400 [thread overview]
Message-ID: <20141009163942.GF20940@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20141009081604.7b42ef4c@urahara>
On Thu, Oct 09, 2014 at 08:16:04AM -0700, Stephen Hemminger wrote:
> On Thu, 9 Oct 2014 11:48:38 +0100
> Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> wrote:
>
> > script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
> > there are Compressed kernel modules - xz (LZMA)
> >
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> > ---
> > tools/setup.sh | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/setup.sh b/tools/setup.sh
> > index 369e09e..14e319c 100755
> > --- a/tools/setup.sh
> > +++ b/tools/setup.sh
> > @@ -169,7 +169,8 @@ load_igb_uio_module()
> >
> > /sbin/lsmod | grep -s uio > /dev/null
> > if [ $? -ne 0 ] ; then
> > - if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
> > + sudo modinfo uio > /dev/null
> > + if [ $? -eq 0 ]; then
> > echo "Loading uio module"
> > sudo /sbin/modprobe uio
> > fi
>
> You don't need sudo to run modinfo
>
Right. Other than that though, looks good.
Neil
prev parent reply other threads:[~2014-10-09 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 10:48 Daniel Mrzyglod
2014-10-09 15:16 ` Stephen Hemminger
2014-10-09 16:39 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009163942.GF20940@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).