DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] Modify tools/setup.sh to be compatible with fedora 21
@ 2014-10-09 10:48 Daniel Mrzyglod
  2014-10-09 15:16 ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mrzyglod @ 2014-10-09 10:48 UTC (permalink / raw)
  To: dev

script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
there are Compressed kernel modules - xz (LZMA)

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 tools/setup.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/setup.sh b/tools/setup.sh
index 369e09e..14e319c 100755
--- a/tools/setup.sh
+++ b/tools/setup.sh
@@ -169,7 +169,8 @@ load_igb_uio_module()
 
 	/sbin/lsmod | grep -s uio > /dev/null
 	if [ $? -ne 0 ] ; then
-		if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
+		sudo modinfo uio > /dev/null
+		if [ $? -eq 0 ]; then
 			echo "Loading uio module"
 			sudo /sbin/modprobe uio
 		fi
-- 
2.1.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v2] Modify tools/setup.sh to be compatible with fedora 21
  2014-10-09 10:48 [dpdk-dev] [PATCH v2] Modify tools/setup.sh to be compatible with fedora 21 Daniel Mrzyglod
@ 2014-10-09 15:16 ` Stephen Hemminger
  2014-10-09 16:39   ` Neil Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2014-10-09 15:16 UTC (permalink / raw)
  To: Daniel Mrzyglod; +Cc: dev

On Thu,  9 Oct 2014 11:48:38 +0100
Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> wrote:

> script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
> there are Compressed kernel modules - xz (LZMA)
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>  tools/setup.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/setup.sh b/tools/setup.sh
> index 369e09e..14e319c 100755
> --- a/tools/setup.sh
> +++ b/tools/setup.sh
> @@ -169,7 +169,8 @@ load_igb_uio_module()
>  
>  	/sbin/lsmod | grep -s uio > /dev/null
>  	if [ $? -ne 0 ] ; then
> -		if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
> +		sudo modinfo uio > /dev/null
> +		if [ $? -eq 0 ]; then
>  			echo "Loading uio module"
>  			sudo /sbin/modprobe uio
>  		fi

You don't need sudo to run modinfo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v2] Modify tools/setup.sh to be compatible with fedora 21
  2014-10-09 15:16 ` Stephen Hemminger
@ 2014-10-09 16:39   ` Neil Horman
  0 siblings, 0 replies; 3+ messages in thread
From: Neil Horman @ 2014-10-09 16:39 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

On Thu, Oct 09, 2014 at 08:16:04AM -0700, Stephen Hemminger wrote:
> On Thu,  9 Oct 2014 11:48:38 +0100
> Daniel Mrzyglod <danielx.t.mrzyglod@intel.com> wrote:
> 
> > script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
> > there are Compressed kernel modules - xz (LZMA)
> > 
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> > ---
> >  tools/setup.sh | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/setup.sh b/tools/setup.sh
> > index 369e09e..14e319c 100755
> > --- a/tools/setup.sh
> > +++ b/tools/setup.sh
> > @@ -169,7 +169,8 @@ load_igb_uio_module()
> >  
> >  	/sbin/lsmod | grep -s uio > /dev/null
> >  	if [ $? -ne 0 ] ; then
> > -		if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
> > +		sudo modinfo uio > /dev/null
> > +		if [ $? -eq 0 ]; then
> >  			echo "Loading uio module"
> >  			sudo /sbin/modprobe uio
> >  		fi
> 
> You don't need sudo to run modinfo
> 

Right.  Other than that though, looks good.
Neil

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-09 16:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-09 10:48 [dpdk-dev] [PATCH v2] Modify tools/setup.sh to be compatible with fedora 21 Daniel Mrzyglod
2014-10-09 15:16 ` Stephen Hemminger
2014-10-09 16:39   ` Neil Horman

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git