From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id CE0B37E7B for ; Wed, 22 Oct 2014 15:31:35 +0200 (CEST) Received: by mail-pd0-f171.google.com with SMTP id ft15so3544879pdb.16 for ; Wed, 22 Oct 2014 06:39:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=pTg4/F003Cj1poBf4YTnLqRfNiEGirII7f3TBoyKfn8=; b=GX/xHolyJzFtMd05Lvtse3C/EC0wsKXEDs/YMgUBuKuaV7pwEJA/lAAGAMo6JIcG20 Ten6Cigf79W3AZvVxSPSqJzxtZaiQuUrXA9xLYWYSUhCNfGt4Kqf8gsyY6CfJUjHkIlZ VmOXAKqWamDXG2eDFodWLxXWLB7WoEtxqw2UT92F3X+TWDVGE1ObuLt0B07YU4QnmbIS rJbDKeZr/SbmqDUDq1TIFcdDHLpaCGDgpY1q9ZNEjevsDvW2GFa73MX9PQqTN0T7qYWU VBhUllYSjGziBmOXE6lWEwBTEFhNGYpUPyJFupl+kH6nQjIrpIs4K59HmwKb/aXfUZSS D7TQ== X-Gm-Message-State: ALoCoQlvnfZDdHsr6Q9VFbf4G1oBPzMWuyIoyXETfJlRQwGRRl3xye03NuCE/1gBKzrjl2eEIMhi X-Received: by 10.68.143.226 with SMTP id sh2mr42327910pbb.62.1413985195446; Wed, 22 Oct 2014 06:39:55 -0700 (PDT) Received: from uryu.home.lan ([14.141.84.68]) by mx.google.com with ESMTPSA id of9sm14322630pbc.6.2014.10.22.06.39.53 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 22 Oct 2014 06:39:55 -0700 (PDT) Date: Wed, 22 Oct 2014 19:09:33 +0530 From: Stephen Hemminger To: Yong Wang Message-ID: <20141022190933.44549786@uryu.home.lan> In-Reply-To: References: <1413181389-14887-1-git-send-email-yongwang@vmware.com> <1413181389-14887-2-git-send-email-yongwang@vmware.com> <20141013113146.202b5eb3@uryu.home.lan> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 13:31:36 -0000 On Mon, 13 Oct 2014 18:42:18 +0000 Yong Wang wrote: > Are you referring to the patch as a whole or your comment is about the reset of vlan_tci on the "else" (no vlan tags stripped) path? I am not sure I get your comments here. This patch simply fixes a bug on the rx vlan stripping path (where valid vlan_tci stripped is overwritten unconditionally later on the rx path in the original vmxnet3 pmd driver). All the other pmd drivers are doing the same thing in terms of translating descriptor status to rte_mbuf flags for vlan stripping. I was thinking that there are many fields in a pktmbuf and rather than individually setting them (like tci). The code should call the common rte_pktmbuf_reset before setting the fields. That way when someone adds a field to mbuf they don't have to chasing through every driver that does it's own initialization.