From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 680725917 for ; Tue, 28 Oct 2014 12:52:56 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 28 Oct 2014 05:01:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="407214170" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 28 Oct 2014 04:53:16 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id s9SC1Gnt020731; Tue, 28 Oct 2014 12:01:16 GMT Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id s9SC1GkS000790; Tue, 28 Oct 2014 12:01:16 GMT Received: (from smonroy@localhost) by sivswdev02.ir.intel.com with id s9SC1GVr000786; Tue, 28 Oct 2014 12:01:16 GMT Date: Tue, 28 Oct 2014 12:01:16 +0000 From: Sergio Gonzalez Monroy To: Pablo de Lara Message-ID: <20141028120115.GA20945@sivswdev02.ir.intel.com> References: <1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com> <1413976621-27430-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1413976621-27430-1-git-send-email-pablo.de.lara.guarch@intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] librte_ip_frag: Disable ipv4/v6 fragmentation if RTE_MBUF_REFCNT=n X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 11:52:56 -0000 On Wed, Oct 22, 2014 at 12:17:01PM +0100, Pablo de Lara wrote: > rte_ipv4_fragment_packet() and rte_ipv6_fragment packet() > call rte_pktmbuf_attach() to attach the segment of the original > packet to the segment of the new fragmented one. Such function > is not declared if RTE_MBUF_REFCNT is disabled, as it needs to > call rte_mbuf_refcnt_update, not declared either. > > Therefore, the ipv4/v6 fragmentation libraries are disabled > in that situation. > > Signed-off-by: Pablo de Lara > --- > lib/librte_ip_frag/Makefile | 6 +++++- > lib/librte_ip_frag/rte_ip_frag.h | 5 ++++- > 2 files changed, 9 insertions(+), 2 deletions(-) > Acked-by: Sergio Gonzalez Monroy