From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <smonroy@ecsmtp.ir.intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 04EFD7DFC
 for <dev@dpdk.org>; Tue, 28 Oct 2014 15:42:38 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 28 Oct 2014 07:49:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,802,1406617200"; d="scan'208";a="597684716"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by orsmga001.jf.intel.com with ESMTP; 28 Oct 2014 07:51:24 -0700
Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com
 [10.237.217.46])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 s9SEpNIX028809; Tue, 28 Oct 2014 14:51:23 GMT
Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1])
 by sivswdev02.ir.intel.com with ESMTP id s9SEpNWQ026922;
 Tue, 28 Oct 2014 14:51:23 GMT
Received: (from smonroy@localhost)
 by sivswdev02.ir.intel.com with  id s9SEpN74026918;
 Tue, 28 Oct 2014 14:51:23 GMT
Date: Tue, 28 Oct 2014 14:51:23 +0000
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Message-ID: <20141028145123.GA24266@sivswdev02.ir.intel.com>
References: <1414078550-692-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D89722637456@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D89722637456@IRSMSX108.ger.corp.intel.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: link combined lib using CC
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2014 14:42:39 -0000

On Tue, Oct 28, 2014 at 11:45:28AM +0000, De Lara Guarch, Pablo wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> > Monroy
> > Sent: Thursday, October 23, 2014 4:36 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] mk: link combined lib using CC
> > 
> > Building combined shared libs fails if we set EXTRA_CFLAGS=-O0.
> > 
> > /usr/bin/ld: test: hidden symbol `mknod' in
> > /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO
> > /usr/bin/ld: final link failed: Bad value
> > collect2: error: ld returned 1 exit status
> > 
> > Fix: link combined shared lib using CC if LINK_USING_CC is enabled.
> > 
> > Signed-off-by: Sergio Gonzalez Monroy
> > <sergio.gonzalez.monroy@intel.com>
> 
> Plus, should we include compilation errors in commits? 
> They are quite useful to identify the problem that 
> the patch is solving, but not sure if this should be shown in the git log.
> 
I was wondering about it myself. I think it is useful info but maybe t is more
appropiate to have it as a comment or cover letter just on the mailing list.
I don't have a strong preference for including it, maybe someone else has an
opinion about this?

Thanks,
Sergio

> Thanks,
> Pablo
>