From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A3DE57E80 for ; Tue, 28 Oct 2014 16:30:31 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 28 Oct 2014 08:37:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,803,1406617200"; d="scan'208";a="626991782" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 28 Oct 2014 08:39:10 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id s9SFd9KB006383; Tue, 28 Oct 2014 15:39:09 GMT Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id s9SFd93h001201; Tue, 28 Oct 2014 15:39:09 GMT Received: (from smonroy@localhost) by sivswdev02.ir.intel.com with id s9SFd83e001197; Tue, 28 Oct 2014 15:39:08 GMT Date: Tue, 28 Oct 2014 15:39:08 +0000 From: Sergio Gonzalez Monroy To: Thomas Monjalon Message-ID: <20141028153908.GB24266@sivswdev02.ir.intel.com> References: <1414078550-692-1-git-send-email-sergio.gonzalez.monroy@intel.com> <20141028145123.GA24266@sivswdev02.ir.intel.com> <1475630.rsklqHVhi2@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475630.rsklqHVhi2@xps13> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: link combined lib using CC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 15:30:32 -0000 On Tue, Oct 28, 2014 at 04:33:18PM +0100, Thomas Monjalon wrote: > 2014-10-28 14:51, Sergio Gonzalez Monroy: > > On Tue, Oct 28, 2014 at 11:45:28AM +0000, De Lara Guarch, Pablo wrote: > > > > Building combined shared libs fails if we set EXTRA_CFLAGS=-O0. > > > > > > > > /usr/bin/ld: test: hidden symbol `mknod' in > > > > /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO > > > > /usr/bin/ld: final link failed: Bad value > > > > collect2: error: ld returned 1 exit status > > > > > > > > Fix: link combined shared lib using CC if LINK_USING_CC is enabled. > > > > > > > > Signed-off-by: Sergio Gonzalez Monroy > > > > > > Plus, should we include compilation errors in commits? > > > They are quite useful to identify the problem that > > > the patch is solving, but not sure if this should be shown in the git log. > > > > > I was wondering about it myself. I think it is useful info but maybe t is more > > appropiate to have it as a comment or cover letter just on the mailing list. > > I don't have a strong preference for including it, maybe someone else has an > > opinion about this? > > We are not limited in characters in the commit log. So every useful information > (like error output) is more than welcome. > The only thing which needs to be shorter than a twitter post, is the title. > Because short and clear titles help to scroll commits. > > That said, don't put things which have no interest at all. Here I'd put only this: > ld: test: hidden symbol `mknod' in /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO > Thanks for the tips! I'll send a v2 with changes. Sergio > -- > Thomas