From: Matthew Hall <mhall@mhcomputing.net>
To: linhaifeng <haifeng.lin@huawei.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] support free hugepages
Date: Wed, 29 Oct 2014 20:17:37 -0700 [thread overview]
Message-ID: <20141030031737.GB3286@mhcomputing.net> (raw)
In-Reply-To: <1414561659-7408-1-git-send-email-haifeng.lin@huawei.com>
On Wed, Oct 29, 2014 at 01:47:39PM +0800, linhaifeng wrote:
> +int
> +rte_eal_hugepage_free(void)
> +{
> + struct hugepage_file *hugepg_tbl = g_hugepage_table.hugepg_tbl;
> + unsigned i;
> + unsigned nr_hugefiles = g_hugepage_table.nr_hugefiles;
> + int ret = 0;
> +
> + for (i = 0; i < nr_hugefiles; i++) {
> + ret = unlink(hugepg_tbl[i].filepath);
> + if (ret != 0) {
> + RTE_LOG(ERR, EAL, "Failed to unlink %s", hugepg_tbl[i].filepath);
> + return ret;
I would say, don't exit just because one couldn't be freed. Free everything
you can but exit with an error so people can know what happened.
Thanks for the patch, good idea!
Matthew.
next prev parent reply other threads:[~2014-10-30 3:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 5:47 linhaifeng
2014-10-29 6:14 ` Qiu, Michael
2014-10-29 6:40 ` Linhaifeng
2014-10-29 8:04 ` Qiu, Michael
2014-10-29 8:15 ` Linhaifeng
2014-10-30 3:17 ` Matthew Hall [this message]
2014-10-30 15:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030031737.GB3286@mhcomputing.net \
--to=mhall@mhcomputing.net \
--cc=dev@dpdk.org \
--cc=haifeng.lin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).