From: Bruce Richardson <bruce.richardson@intel.com>
To: Matthew Hall <mhall@mhcomputing.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal_pci.c: pci_scan_one: fix inaccurate NUMA node error comment
Date: Thu, 30 Oct 2014 09:57:34 +0000 [thread overview]
Message-ID: <20141030095734.GB4460@bricha3-MOBL3> (raw)
In-Reply-To: <1414640408-10118-1-git-send-email-mhall@mhcomputing.net>
On Thu, Oct 30, 2014 at 03:40:08AM +0000, Matthew Hall wrote:
> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index 5fe3961..ddb0535 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -266,7 +266,7 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
> snprintf(filename, sizeof(filename), "%s/numa_node",
> dirname);
> if (access(filename, R_OK) != 0) {
> - /* if no NUMA support just set node to 0 */
> + /* if no NUMA support just set node to -1 */
> dev->numa_node = -1;
> } else {
> if (eal_parse_sysfs_value(filename, &tmp) < 0) {
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-10-30 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 3:40 Matthew Hall
2014-10-30 9:57 ` Bruce Richardson [this message]
2014-11-05 21:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030095734.GB4460@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mhall@mhcomputing.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).