From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id AF36B7EC4 for ; Fri, 7 Nov 2014 14:40:02 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 07 Nov 2014 05:49:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,332,1413270000"; d="scan'208";a="628319636" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.32]) by fmsmga002.fm.intel.com with SMTP; 07 Nov 2014 05:49:30 -0800 Received: by (sSMTP sendmail emulation); Fri, 07 Nov 2014 13:49:30 +0025 Date: Fri, 7 Nov 2014 13:49:30 +0000 From: Bruce Richardson To: Thomas Monjalon Message-ID: <20141107134929.GA12092@bricha3-MOBL3> References: <1410948102-12740-1-git-send-email-bruce.richardson@intel.com> <20140923170231.GC12884@hmsreliant.think-freely.org> <59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com> <2215672.o2GmOzFsZU@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2215672.o2GmOzFsZU@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 13:40:03 -0000 On Fri, Nov 07, 2014 at 01:30:53PM +0100, Thomas Monjalon wrote: > Hi Bruce, > > 2014-09-24 09:03, Richardson, Bruce: > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > > On Tue, Sep 23, 2014 at 12:08:15PM +0100, Bruce Richardson wrote: > > > > --- a/app/test-pmd/testpmd.c > > > > +++ b/app/test-pmd/testpmd.c > > > > @@ -225,7 +225,9 @@ struct rte_eth_thresh tx_thresh = { > > > > /* > > > > * Configurable value of RX free threshold. > > > > */ > > > > -uint16_t rx_free_thresh = 0; /* Immediately free RX descriptors by default. */ > > > > +uint16_t rx_free_thresh = 32; /* Refill RX descriptors once every 32 packets, > > > > + This setting is needed for ixgbe to enable bulk alloc or vector > > > > + receive functionality. */ > > > > > > I thought we were talking about making this a pmd private selectable item, > > > or allowing a reserved "let the pmd decide" setting. Or are we saving > > > that for a later time? > > > > Yes, we are looking at that - and hopefully we can also get a patch for that > > in for our next release. However, I've left this patch in just in case that > > doesn't actually happen, as the performance improvements for 10G are just > > too good to leave aside for the sake of a 1-line change. Ideally, I'd like > > this go to in, and then be replaced by a "proper" fix. > > Now the patch for PMD defaults is integrated: > http://dpdk.org/ml/archives/dev/2014-October/006511.html > Are you working on getting these defaults in testpmd? > Not at the minute, as I'm busy on other things. If I find time I can look at it, though, if nobody else volunteers to do so first. /Bruce > Thanks > -- > Thomas