From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id D0B2D594F for ; Thu, 13 Nov 2014 12:04:42 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1XosM9-0002jA-P2; Thu, 13 Nov 2014 06:14:36 -0500 Date: Thu, 13 Nov 2014 06:14:29 -0500 From: Neil Horman To: Thomas Monjalon Message-ID: <20141113111428.GA13253@hmsreliant.think-freely.org> References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com> <4230474.fJnSGQJdQd@xps13> <20141008191403.GB13306@hmsreliant.think-freely.org> <1898542.t3c6y266ZQ@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1898542.t3c6y266ZQ@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org, John Linville Subject: Re: [dpdk-dev] [PATCH v2] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 11:04:43 -0000 On Thu, Nov 13, 2014 at 02:03:18AM -0800, Thomas Monjalon wrote: > Hi Neil and John, > > I would like to wake up this very old thread. > > 2014-10-08 15:14, Neil Horman: > > On Wed, Oct 08, 2014 at 05:57:46PM +0200, Thomas Monjalon wrote: > > > 2014-09-29 11:05, Bruce Richardson: > > > > On Fri, Sep 26, 2014 at 10:08:55AM -0400, Neil Horman wrote: > > > > > On Fri, Sep 26, 2014 at 11:28:05AM +0200, Thomas Monjalon wrote: > > > > > > 3) There is no test associated with this PMD. > > > > > That would have been a great comment to make a few months back, though whats > > > > > wrong with testpmd here? That seems to be the same test that every other pmd > > > > > uses. What exactly are you looking for? > > > > > > I was thinking of testing behaviour with different kernel configurations and > > > unit tests for --vdev options. But it's not a major blocker. > > > > > Thats fine with me. If theres a set of unit tests that you have documentation > > for, I'm sure we would be happy to run them. I presume you just want all the > > pmd vdev option exercised? Any specific sets of kernel configurations? > > I don't really know which tests are needed. It could be a mix of unit tests > and functionnal tests described in a test plan. > The goal is to be able to validate the behaviour and check there is no > regression. Ideally some corner cases could be described. > I'm OK to integrate it as is. But future maintenance will probably need > such inputs for validation tests. > Do you have an example set of tests that the other pmd's have followed for this? > > > If RedHat is committed for its maintenance, it could integrated in release 1.8. > > > But I'd like it to be renamed as pmd_af_packet (or a better name) instead of > > > pmd_packet. > > > > > John L. is on his way to plumbers at the moment, so is unable to comment, but > > I'll try to get a few cycles to change the name of the PMD around. And yes, I > > thought that maintenance was implicit. He's the author, of course he'll take > > care of it :). And I'll be glad to help > > Do you have time in coming days to rebase and rename this PMD for inclusion > in 1.8.0 release? > > Thanks > -- > Thomas >